linux-kernel - RE: [PATCH v0 1/3] dt-binding: aspeed: Add LPC PCC controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PSAPR06MB494959646EC7A8447056777B89FA2@PSAPR06MB4949.apcprd06.prod.outlook.com>
Date: Tue, 18 Feb 2025 11:05:16 +0000
From: Kevin Chen <kevin_chen@...eedtech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "joel@....id.au" <joel@....id.au>,
	"andrew@...econstruct.com.au" <andrew@...econstruct.com.au>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "elbadrym@...gle.com" <elbadrym@...gle.com>
Subject: RE: [PATCH v0 1/3] dt-binding: aspeed: Add LPC PCC controller

> On 13/02/2025 09:46, Kevin Chen wrote:
> >> On 17/01/2025 10:52, Kevin Chen wrote:
> >>> Add dt-bindings for Aspeed for Aspeed LPC POST code capture controller.
> >>>
> >>> Signed-off-by: Kevin Chen <kevin_chen@...eedtech.com>
> >>> ---
> >>
> >> Patchsets start from 1, not 0.
> > Agree, I will resend the patchsets of v1.
> >
> >>
> >> This wasn't tested as it has obvious errors, so no review. Test your
> >> patches before you send them.
> > Agree, I will run "make dtbs_check W=1" and " make dt_binding_check " to
> check result is clean before the next commits.
> >
> >>
> >>
> >> <form letter>
> >> Please use scripts/get_maintainers.pl to get a list of necessary
> >> people and lists to CC. It might happen, that command when run on an
> >> older kernel, gives you outdated entries. Therefore please be sure
> >> you base your patches on recent Linux kernel.
> >>
> >> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> >> people, so fix your workflow. Tools might also fail if you work on
> >> some ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline).
> >> Just use b4 and everything should be fine, although remember about
> >> `b4 prep --auto-to-cc` if you added new patches to the patchset.
> >>
> >> You missed at least devicetree list (maybe more), so this won't be
> >> tested by automated tooling. Performing review on untested code might
> >> be a waste of time.
> >>
> >> Please kindly resend and include all necessary To/Cc entries.
> >> </form letter>
> 
> How did you implement this feedback?

make dtbs_check W=1
# Check the lpc-pcc or pcc message from the log

make dt_binding_check 
# No Error

make coccicheck MODE=report
# Stop at the following log but no related log.
#   OCaml scripting is unsupported.
#   coccicheck failed


> 
> Best regards,
> Krzysztof