linux-kernel - Re: [PATCH net-next v2] net: Remove redundant variable declaration in __dev_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH-L+nNXaM+P_1-HuE-w3XoCMraGA+4RhCm8L63LmHVmstXeCQ@mail.gmail.com>
Date: Tue, 18 Feb 2025 08:25:22 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Breno Leitao <leitao@...ian.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Nicolas Dichtel <nicolas.dichtel@...nd.com>, andrew@...n.ch, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	Mateusz Polchlopek <mateusz.polchlopek@...el.com>
Subject: Re: [PATCH net-next v2] net: Remove redundant variable declaration in __dev_change_flags()

On Mon, Feb 17, 2025 at 9:21 PM Breno Leitao <leitao@...ian.org> wrote:
>
> The old_flags variable is declared twice in __dev_change_flags(),
> causing a shadow variable warning. This patch fixes the issue by
> removing the redundant declaration, reusing the existing old_flags
> variable instead.
>
>         net/core/dev.c:9225:16: warning: declaration shadows a local variable [-Wshadow]
>         9225 |                 unsigned int old_flags = dev->flags;
>         |                              ^
>         net/core/dev.c:9185:15: note: previous declaration is here
>         9185 |         unsigned int old_flags = dev->flags;
>         |                      ^
>         1 warning generated.
>
> Remove the redundant inner declaration and reuse the existing old_flags
> variable since its value is not needed outside the if block, and it is
> safe to reuse the variable. This eliminates the warning while
> maintaining the same functionality.
>
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>

LGTM,
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>

-- 
Regards,
Kalesh AP

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)