linux-kernel - Re: [PATCH 2/2] mm/truncate: don't skip dirty page in folio_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cedbmhuivcr2imkzuqebrrihdkfsmgqmplqqn7s2fusk3v4ezq@7jbz26dds76d>
Date: Tue, 18 Feb 2025 14:32:58 +0200
From: "Kirill A. Shutemov" <kirill@...temov.name>
To: Jingbo Xu <jefflexu@...ux.alibaba.com>
Cc: axboe@...nel.dk, linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, 
	brauner@...nel.org, linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk
Subject: Re: [PATCH 2/2] mm/truncate: don't skip dirty page in
 folio_unmap_invalidate()

On Tue, Feb 18, 2025 at 08:02:09PM +0800, Jingbo Xu wrote:
> ... otherwise this is a behavior change for the previous callers of
> invalidate_complete_folio2(), e.g. the page invalidation routine.

Hm. Shouldn't the check be moved to caller of the helper in mm/filemap.c?

Otherwise we would drop pages without writing them back. And lose user's
data.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov