linux-kernel - Re: [PATCH v2 2/3] rust: configfs: introduce rust support for configfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87frkbflfe.fsf@kernel.org>
Date: Tue, 18 Feb 2025 14:10:29 +0100
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Danilo Krummrich" <dakr@...nel.org>
Cc: "Benno Lossin" <benno.lossin@...ton.me>,  "Miguel Ojeda"
 <ojeda@...nel.org>,  "Alex Gaynor" <alex.gaynor@...il.com>,  "Boqun Feng"
 <boqun.feng@...il.com>,  "Gary Guo" <gary@...yguo.net>,  Björn Roy Baron
 <bjorn3_gh@...tonmail.com>,  "Alice Ryhl" <aliceryhl@...gle.com>,  "Trevor
 Gross" <tmgross@...ch.edu>,  "Joel Becker" <jlbec@...lplan.org>,
  "Christoph Hellwig" <hch@....de>,  "Peter Zijlstra"
 <peterz@...radead.org>,  "Ingo Molnar" <mingo@...hat.com>,  "Will Deacon"
 <will@...nel.org>,  "Waiman Long" <longman@...hat.com>,  "Fiona Behrens"
 <me@...enk.dev>,  "Charalampos Mitrodimas" <charmitro@...teo.net>,
  <rust-for-linux@...r.kernel.org>,  <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/3] rust: configfs: introduce rust support for configfs

"Danilo Krummrich" <dakr@...nel.org> writes:

> On Mon, Feb 17, 2025 at 12:08:22PM +0100, Andreas Hindborg wrote:
>> "Benno Lossin" <benno.lossin@...ton.me> writes:
>>
>> > On 07.02.25 15:41, Andreas Hindborg wrote:

[...]

>> >> +    /// Implementations can use this method to do house keeping before
>> >> +    /// `configfs` drops its reference to `Child`.
>> >> +    fn drop_item(
>> >
>> > `drop` doesn't really fit here, I think something like `unlink_item`
>> > fits better, since the child isn't actually dropped after this function
>> > returns.
>>
>> Yea, I know. But the function is called `drop_item` on the C side of
>> things. Usually we keep the C names.
>
> I agree C names should be kept as possible.
>
> To me it seems obvious from the context, but maybe it'd still makes sense to add
> a brief note that this callback's name is not related to 'drop' in the sense of
> Rust?

Yes, good idea. I'll get than in for v4.


Best regards,
Andreas Hindborg