linux-kernel - Re: [PATCH v3 bpf 0/2] bpf: skip non exist keys in generic_map_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <173992923201.98087.10855762431625409310.git-patchwork-notify@kernel.org>
Date: Wed, 19 Feb 2025 01:40:32 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Yan Zhai <yan@...udflare.com>
Cc: bpf@...r.kernel.org, ast@...nel.org, daniel@...earbox.net,
 john.fastabend@...il.com, andrii@...nel.org, martin.lau@...ux.dev,
 eddyz87@...il.com, song@...nel.org, yonghong.song@...ux.dev,
 kpsingh@...nel.org, sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org,
 mykolal@...com, shuah@...nel.org, brianvv@...gle.com,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 kernel-team@...udflare.com, houtao@...weicloud.com
Subject: Re: [PATCH v3 bpf 0/2] bpf: skip non exist keys in
 generic_map_lookup_batch

Hello:

This series was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@...nel.org>:

On Sun, 9 Feb 2025 23:22:31 -0800 you wrote:
> The generic_map_lookup_batch currently returns EINTR if it fails with
> ENOENT and retries several times on bpf_map_copy_value. The next batch
> would start from the same location, presuming it's a transient issue.
> This is incorrect if a map can actually have "holes", i.e.
> "get_next_key" can return a key that does not point to a valid value. At
> least the array of maps type may contain such holes legitly. Right now
> these holes show up, generic batch lookup cannot proceed any more. It
> will always fail with EINTR errors.
> 
> [...]

Here is the summary with links:
  - [v3,bpf,1/2] bpf: skip non exist keys in generic_map_lookup_batch
    https://git.kernel.org/bpf/bpf/c/5644c6b50ffe
  - [v3,bpf,2/2] selftests: bpf: test batch lookup on array of maps with holes
    https://git.kernel.org/bpf/bpf/c/d66b7739176d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html