linux-kernel - Re: [PATCH] drm/xe: Add check for alloc_ordered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4uovznb72ljcirafrpwr5ynkpsx66bc3gcn4xxhqpwooshydea@b7suaeje6agd>
Date: Wed, 19 Feb 2025 09:00:49 -0600
From: Lucas De Marchi <lucas.demarchi@...el.com>
To: Haoxiang Li <haoxiang_li2024@....com>
CC: <thomas.hellstrom@...ux.intel.com>, <rodrigo.vivi@...el.com>,
	<maarten.lankhorst@...ux.intel.com>, <mripard@...nel.org>,
	<tzimmermann@...e.de>, <airlied@...il.com>, <simona@...ll.ch>,
	<himal.prasad.ghimiray@...el.com>, <badal.nilawar@...el.com>,
	<matthew.brost@...el.com>, <intel-xe@...ts.freedesktop.org>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
	<stable@...r.kernel.org>
Subject: Re: [PATCH] drm/xe: Add check for alloc_ordered_workqueue()

On Wed, Feb 19, 2025 at 05:56:59PM +0800, Haoxiang Li wrote:
>Add check for the return value of alloc_ordered_workqueue()
>in xe_gt_alloc() to catch potential exception.
>
>Fixes: e2d84e5b2205 ("drm/xe: Mark GT work queue with WQ_MEM_RECLAIM")
>Cc: stable@...r.kernel.org
>Signed-off-by: Haoxiang Li <haoxiang_li2024@....com>

Reviewed-by: Lucas De Marchi <lucas.demarchi@...el.com>

thanks
Lucas De Marchi

>---
> drivers/gpu/drm/xe/xe_gt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
>index 5d6fb79957b6..0f42bbcb8d42 100644
>--- a/drivers/gpu/drm/xe/xe_gt.c
>+++ b/drivers/gpu/drm/xe/xe_gt.c
>@@ -79,6 +79,8 @@ struct xe_gt *xe_gt_alloc(struct xe_tile *tile)
> 	gt->tile = tile;
> 	gt->ordered_wq = alloc_ordered_workqueue("gt-ordered-wq",
> 						 WQ_MEM_RECLAIM);
>+	if (!gt->ordered_wq)
>+		return ERR_PTR(-ENOMEM);
>
> 	err = drmm_add_action_or_reset(&gt_to_xe(gt)->drm, gt_fini, gt);
> 	if (err)
>-- 
>2.25.1
>