linux-kernel - [PATCH] qedi_iscsi: remove dead code from qedi_process_iscsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250219150043.1051211-1-den-plotnikov@yandex-team.ru>
Date: Wed, 19 Feb 2025 18:00:43 +0300
From: Denis Plotnikov <den-plotnikov@...dex-team.ru>
To: linux-kernel@...r.kernel.org
Cc: linux-scsi@...r.kernel.org,
	GR-QLogic-Storage-Upstream@...vell.com,
	mrangankar@...vell.com,
	njavali@...vell.com
Subject: [PATCH] qedi_iscsi: remove dead code from qedi_process_iscsi_error()

No functional changes, just dead code removal.

Signed-off-by: Denis Plotnikov <den-plotnikov@...dex-team.ru>
---
 drivers/scsi/qedi/qedi_iscsi.c | 23 +++--------------------
 1 file changed, 3 insertions(+), 20 deletions(-)

diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscsi.c
index 6ed8ef97642c8..1891a55fd83e9 100644
--- a/drivers/scsi/qedi/qedi_iscsi.c
+++ b/drivers/scsi/qedi/qedi_iscsi.c
@@ -1649,12 +1649,6 @@ void qedi_process_iscsi_error(struct qedi_endpoint *ep,
 {
 	struct qedi_conn *qedi_conn;
 	struct qedi_ctx *qedi;
-	char warn_notice[] = "iscsi_warning";
-	char error_notice[] = "iscsi_error";
-	char unknown_msg[] = "Unknown error";
-	char *message;
-	int need_recovery = 0;
-	u32 err_mask = 0;
 	char *msg;
 
 	if (!ep)
@@ -1669,25 +1663,14 @@ void qedi_process_iscsi_error(struct qedi_endpoint *ep,
 	QEDI_ERR(&qedi->dbg_ctx, "async event iscsi error:0x%x\n",
 		 data->error_code);
 
-	if (err_mask) {
-		need_recovery = 0;
-		message = warn_notice;
-	} else {
-		need_recovery = 1;
-		message = error_notice;
-	}
-
 	msg = qedi_get_iscsi_error(data->error_code);
-	if (!msg) {
-		need_recovery = 0;
-		msg = unknown_msg;
-	}
 
 	iscsi_conn_printk(KERN_ALERT,
 			  qedi_conn->cls_conn->dd_data,
-			  "qedi: %s - %s\n", message, msg);
+			  "qedi: %s - %s\n", "iscsi_error",
+			  msg ? msg : "Unknown error");
 
-	if (need_recovery)
+	if (msg)
 		qedi_start_conn_recovery(qedi_conn->qedi, qedi_conn);
 }
 
-- 
2.34.1