linux-kernel - Re: Rust kernel policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1693d15d0a9c8b7d194535f88cbc5b07b5740e5.camel@HansenPartnership.com>
Date: Wed, 19 Feb 2025 10:15:00 -0500
From: James Bottomley <James.Bottomley@...senPartnership.com>
To: "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, Christoph Hellwig
 <hch@...radead.org>, Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, 
 rust-for-linux <rust-for-linux@...r.kernel.org>, Linus Torvalds
 <torvalds@...ux-foundation.org>, Greg KH <gregkh@...uxfoundation.org>,
 David Airlie <airlied@...il.com>,  linux-kernel@...r.kernel.org,
 ksummit@...ts.linux.dev
Subject: Re: Rust kernel policy

On Wed, 2025-02-19 at 09:46 -0500, Martin K. Petersen wrote:
> 
> James,
> 
> > Could we possibly fix a lot of this by adopting the _cleanup_
> > annotations[1]? I've been working in systemd code recently and they
> > seem to make great use of this for error leg simplification.
> 
> We already have this:
> 
>   include/linux/cleanup.h
> 
> I like using cleanup attributes for some error handling. However, I'm
> finding that in many cases I want to do a bit more than a simple
> kfree(). And at that point things get syntactically messy in the
> variable declarations and harder to read than just doing a classic
> goto style unwind.

So the way systemd solves this is that they define a whole bunch of
_cleanup_<type>_ annotations which encode the additional logic.  It
does mean you need a globally defined function for each cleanup type,
but judicious use of cleanup types seems to mean they only have a few
dozen of these.

Regards,

James