linux-kernel - Re: [PATCH v1] usb: core: replace usb_sndaddr0pipe macro with usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8fba35c4-fe72-4dc3-85cf-270efb0c7765@rowland.harvard.edu>
Date: Wed, 19 Feb 2025 10:17:05 -0500
From: Alan Stern <stern@...land.harvard.edu>
To: Stefan Eichenberger <eichest@...il.com>
Cc: gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Stefan Eichenberger <stefan.eichenberger@...adex.com>
Subject: Re: [PATCH v1] usb: core: replace usb_sndaddr0pipe macro with
 usb_sndctrlpipe

On Wed, Feb 19, 2025 at 09:36:44AM +0100, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@...adex.com>
> 
> The usb_sndaddr0pipe macro is only used in the hub_set_address function.
> Replace it with usb_sndctrlpipe which provides the same functionality
> but would also consider the endpoint device number.
> 
> If the device has not been initialised, it is safe to use
> usb_sndctrlpipe in this context because udev->devnum is set to 0.
> Therefore, this change does not affect behaviour, but reduces code
> complexity by reusing the existing macro.
> 
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@...adex.com>
> ---
> Even though this patch does not fix a bug it is related to the following
> discussion and addresses the change proposed by Alan:
> https://lore.kernel.org/all/aa0c06f6-f997-4bcf-a5a3-6b17f6355fca@rowland.harvard.edu/
> ---

Acked-by: Alan Stern <stern@...land.harvard.edu>

>  drivers/usb/core/hub.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 59e38780f76d0..66dfdf0bab90b 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -4697,8 +4697,6 @@ void usb_ep0_reinit(struct usb_device *udev)
>  }
>  EXPORT_SYMBOL_GPL(usb_ep0_reinit);
>  
> -#define usb_sndaddr0pipe()	(PIPE_CONTROL << 30)
> -
>  static int hub_set_address(struct usb_device *udev, int devnum)
>  {
>  	int retval;
> @@ -4722,7 +4720,7 @@ static int hub_set_address(struct usb_device *udev, int devnum)
>  	if (hcd->driver->address_device)
>  		retval = hcd->driver->address_device(hcd, udev, timeout_ms);
>  	else
> -		retval = usb_control_msg(udev, usb_sndaddr0pipe(),
> +		retval = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
>  				USB_REQ_SET_ADDRESS, 0, devnum, 0,
>  				NULL, 0, timeout_ms);
>  	if (retval == 0) {
> -- 
> 2.45.2
>