linux-kernel - Re: [PATCH] drm/i915/display: Add check for alloc_ordered_workqueue() and alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wmdmlzvf.fsf@intel.com>
Date: Wed, 19 Feb 2025 17:26:28 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Haoxiang Li <haoxiang_li2024@....com>, rodrigo.vivi@...el.com,
 joonas.lahtinen@...ux.intel.com, tursulin@...ulin.net, airlied@...il.com,
 simona@...ll.ch, gustavo.sousa@...el.com
Cc: intel-gfx@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, Haoxiang Li
 <haoxiang_li2024@....com>, stable@...r.kernel.org
Subject: Re: [PATCH] drm/i915/display: Add check for
 alloc_ordered_workqueue() and alloc_workqueue()

On Wed, 19 Feb 2025, Haoxiang Li <haoxiang_li2024@....com> wrote:
> Add check for the return value of alloc_ordered_workqueue()
> and alloc_workqueue() to catch potential exception.
>
> Fixes: 40053823baad ("drm/i915/display: move modeset probe/remove functions to intel_display_driver.c")

Not really. That's just code movement.

> Cc: stable@...r.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024@....com>
> ---
>  drivers/gpu/drm/i915/display/intel_display_driver.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_driver.c b/drivers/gpu/drm/i915/display/intel_display_driver.c
> index 50ec0c3c7588..dfe5b779aefd 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_driver.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_driver.c
> @@ -245,6 +245,11 @@ int intel_display_driver_probe_noirq(struct intel_display *display)
>  						WQ_UNBOUND, WQ_UNBOUND_MAX_ACTIVE);
>  	display->wq.cleanup = alloc_workqueue("i915_cleanup", WQ_HIGHPRI, 0);
>  
> +	if (!display->wq.modeset || !display->wq.flip || !display->wq.cleanup) {
> +		ret = -ENOMEM;
> +		goto cleanup_vga_client_pw_domain_dmc;
> +	}
> +

Yes, we should check these, but if some of them succeed and some fail,
we'll never destroy the workqueues whose allocation succeeded.

BR,
Jani.


>  	intel_mode_config_init(display);
>  
>  	ret = intel_cdclk_init(display);

-- 
Jani Nikula, Intel