linux-kernel - Re: [PATCH v2 2/5] rtc-rv8803: add new type for rv8901

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7X51iji1R8X0UAJ@mt.com>
Date: Wed, 19 Feb 2025 16:33:42 +0100
From: Manuel Traut <manuel.traut@...com>
To: Markus Burri <markus.burri@...com>
Cc: linux-kernel@...r.kernel.org,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Marek Vasut <marex@...x.de>,
	linux-rtc@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/5] rtc-rv8803: add new type for rv8901

On Thu, Jan 16, 2025 at 02:15:29PM +0100, Markus Burri wrote:
> The rtc-rv8901 has additional functionality (tamper detection).
> To support this additional functionality the type must be extended.
> 
> Signed-off-by: Markus Burri <markus.burri@...com>

Reviewed-by: Manuel Traut <manuel.traut@...com>

> ---
>  drivers/rtc/rtc-rv8803.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c
> index 1327251e5..50fbae931 100644
> --- a/drivers/rtc/rtc-rv8803.c
> +++ b/drivers/rtc/rtc-rv8803.c
> @@ -62,7 +62,8 @@ enum rv8803_type {
>  	rv_8803,
>  	rx_8803,
>  	rx_8804,
> -	rx_8900
> +	rx_8900,
> +	rx_8901,
>  };
>  
>  struct rv8803_data {
> @@ -173,7 +174,8 @@ static int rv8803_regs_reset(struct rv8803_data *rv8803, bool full)
>  	 * The RV-8803 resets all registers to POR defaults after voltage-loss,
>  	 * the Epson RTCs don't, so we manually reset the remainder here.
>  	 */
> -	if (full || rv8803->type == rx_8803 || rv8803->type == rx_8900) {
> +	if (full || rv8803->type == rx_8803 || rv8803->type == rx_8900 ||
> +	    rv8803->type == rx_8901) {
>  		int ret = rv8803_regs_init(rv8803);
>  		if (ret)
>  			return ret;
> @@ -635,6 +637,7 @@ static const struct i2c_device_id rv8803_id[] = {
>  	{ "rv8804", rx_8804 },
>  	{ "rx8803", rx_8803 },
>  	{ "rx8900", rx_8900 },
> +	{ "rx8901", rx_8901 },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, rv8803_id);
> @@ -760,6 +763,10 @@ static const __maybe_unused struct of_device_id rv8803_of_match[] = {
>  		.compatible = "epson,rx8900",
>  		.data = (void *)rx_8900
>  	},
> +	{
> +		.compatible = "epson,rx8901",
> +		.data = (void *)rx_8901
> +	},
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, rv8803_of_match);
> -- 
> 2.39.5
>