linux-kernel - Re: [PATCH 00/17] staging: gpib: Console messaging cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025021923-leverage-endpoint-c06e@gregkh>
Date: Wed, 19 Feb 2025 16:48:39 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Dave Penkler <dpenkler@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/17] staging: gpib: Console messaging cleanup

On Fri, Feb 14, 2025 at 12:46:51PM +0100, Dave Penkler wrote:
> The GPIB drivers printed a lot of spurious console messages. This
> was linked to the level of code maturity, often using console
> messages for debug.
> 
> This patch set cleans up the console messaging in the spirit of Greg's
> recommendation: "When drivers are successful, they should be quiet"
> 
> All pr_info's have been removed except for one which is in the module
> init of the common core driver indicating that the GPIB subsystem is
> initialized.
> 
> All dev_info's have been removed or changed to dev_dbg except for the
> attach and probe messages in the agilent and ni usb drivers. This is
> to facilitate the creation of config and udev scripts to ensure that a
> particular usb device is systematically attached to the same gpib
> device file.
> 
> All custom debug and tty logging has been removed or replaced with
> dev_dbg.
> 
> Error messages where the user can figure out what went wrong with
> errno have also been removed, particularly timeouts and interrupts
> during reads and writes which can occur quite frequently uneccessarily
> cluttering up the console log.
> 
> The patches are 1 per driver.

All but 4 of these applied, can you rebase and resend the remaining
ones?

thanks,

greg k-h