linux-kernel - Re: [PATCH v2 06/16] x86/mce: Remove __mcheck_cpu_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250219155317.GA337534@yaz-khff2.amd.com>
Date: Wed, 19 Feb 2025 10:53:17 -0500
From: Yazen Ghannam <yazen.ghannam@....com>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
Cc: "x86@...nel.org" <x86@...nel.org>, "Luck, Tony" <tony.luck@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"Smita.KoralahalliChannabasappa@....com" <Smita.KoralahalliChannabasappa@....com>
Subject: Re: [PATCH v2 06/16] x86/mce: Remove __mcheck_cpu_init_early()

On Tue, Feb 18, 2025 at 03:00:12AM +0000, Zhuo, Qiuxu wrote:
> > From: Yazen Ghannam <yazen.ghannam@....com>
> > Sent: Friday, February 14, 2025 12:46 AM
> > To: x86@...nel.org; Luck, Tony <tony.luck@...el.com>
> > Cc: linux-kernel@...r.kernel.org; linux-edac@...r.kernel.org;
> > Smita.KoralahalliChannabasappa@....com; Yazen Ghannam
> > <yazen.ghannam@....com>
> > Subject: [PATCH v2 06/16] x86/mce: Remove __mcheck_cpu_init_early()
> > 
> > The __mcheck_cpu_init_early() function was introduced so that some
> > vendor-specific features are detected before the first MCA polling event done
> > in __mcheck_cpu_init_generic().
> > 
> > Currently, __mcheck_cpu_init_early() is only used on AMD-based systems
> > and additional code will be needed to support various system configurations.
> > 
> > However, the current and future vendor-specific code should be done during
> > vendor init. This keeps all the vendor code in a common location and
> > simplifies the generic init flow.
> > 
> > Move all the __mcheck_cpu_init_early() code into mce_amd_feature_init().
> > Also, move __mcheck_cpu_init_generic() after
> > __mcheck_cpu_init_prepare_banks() so that MCA is enabled after the first
> > MCA polling event.
> 
> Maybe providing a bit more information about the first MCA polling event, 
> as shown below, would be clearer:
> 
>    "... so that MCA is enabled after the first MCA polling event for the machine 
>     checks left over from the previous reset."
> 

Sure thing.

> > Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>
> 
> Other than that,
> 
>     Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
>   

Thanks,
Yazen