linux-kernel - Re: [PATCH] libbpf: Wrap libbpf API direct err with libbpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88f0c25cc981f958e46d51560fbf6db7136a3fa0.camel@gmail.com>
Date: Tue, 18 Feb 2025 18:08:46 -0800
From: Eduard Zingerman <eddyz87@...il.com>
To: Tao Chen <chen.dylane@...il.com>, ast@...nel.org, daniel@...earbox.net, 
	andrii@...nel.org, haoluo@...gle.com, jolsa@...nel.org, qmo@...nel.org
Cc: bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libbpf: Wrap libbpf API direct err with libbpf_err

On Fri, 2025-02-14 at 22:17 +0800, Tao Chen wrote:
> Just wrap the direct err with libbpf_err, keep consistency
> with other APIs.
> 
> Signed-off-by: Tao Chen <chen.dylane@...il.com>
> ---

While at it, I've noticed two more places that need libbpf_err() calls.
Could you please check the following locations:

bpf_map__set_value_size:
  return -EOPNOTSUPP;       tools/lib/bpf/libbpf.c:10309
  return err;               tools/lib/bpf/libbpf.c:10317

?

Other than that, I agree with changes in this patch.

Acked-by: Eduard Zingerman <eddyz87@...il.com>

[...]