linux-kernel - Re: [PATCH v2 01/14] drivers/perf: apple_m1: Refactor event select/filter configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <868qq1sy47.wl-maz@kernel.org>
Date: Wed, 19 Feb 2025 16:22:32 +0000
From: Marc Zyngier <maz@...nel.org>
To: Oliver Upton <oliver.upton@...ux.dev>
Cc: kvmarm@...ts.linux.dev,
	Joey Gouly <joey.gouly@....com>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Zenghui Yu <yuzenghui@...wei.com>,
	Mingwei Zhang <mizhang@...gle.com>,
	Colton Lewis <coltonlewis@...gle.com>,
	Raghavendra Rao Ananta <rananta@...gle.com>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Janne Grunau <j@...nau.net>
Subject: Re: [PATCH v2 01/14] drivers/perf: apple_m1: Refactor event select/filter configuration

On Mon, 03 Feb 2025 18:30:58 +0000,
Oliver Upton <oliver.upton@...ux.dev> wrote:
> 
> Supporting guest mode events will necessitate programming two event
> filters. Prepare by splitting up the programming of the event selector +
> event filter into separate headers.

s/headers/helpers/ ?

> 
> Opportunistically replace RMW patterns with sysreg_clear_set_s().
> 
> Tested-by: Janne Grunau <j@...nau.net>
> Signed-off-by: Oliver Upton <oliver.upton@...ux.dev>
> ---
>  arch/arm64/include/asm/apple_m1_pmu.h |  1 +
>  drivers/perf/apple_m1_cpu_pmu.c       | 52 ++++++++++++++++-----------
>  2 files changed, 33 insertions(+), 20 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/apple_m1_pmu.h b/arch/arm64/include/asm/apple_m1_pmu.h
> index 99483b19b99f..02e05d05851f 100644
> --- a/arch/arm64/include/asm/apple_m1_pmu.h
> +++ b/arch/arm64/include/asm/apple_m1_pmu.h
> @@ -37,6 +37,7 @@
>  #define PMCR0_PMI_ENABLE_8_9	GENMASK(45, 44)
>  
>  #define SYS_IMP_APL_PMCR1_EL1	sys_reg(3, 1, 15, 1, 0)
> +#define SYS_IMP_APL_PMCR1_EL12	sys_reg(3, 1, 15, 7, 2)

nit: this should be moved to the following patch.

Otherwise looks good to me.

	M.

-- 
Without deviation from the norm, progress is not possible.