linux-kernel - Re: [PATCH v2 1/2] PCI/portdrv: Add necessary wait for disabling hotplug events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7U_xNsQ04_tcTgB@U-2FWC9VHC-2323.local>
Date: Wed, 19 Feb 2025 10:19:48 +0800
From: Feng Tang <feng.tang@...ux.alibaba.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-pci@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
	Guanghui Feng <guanghuifeng@...ux.alibaba.com>,
	Liguang Zhang <zhangliguang@...ux.alibaba.com>,
	Lukas Wunner <lukas@...ner.de>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v2 1/2] PCI/portdrv: Add necessary wait for disabling
 hotplug events

Hi Markus,

On Tue, Feb 18, 2025 at 10:00:33AM +0100, Markus Elfring wrote:
> > There was problem reported by firmware developers that they received
> > 2 pcie link control commands in very short intervals on an ARM server,
> > which doesn't comply with pcie spec, and broke their state machine and
> > work flow. According to PCIe 6.1 spec, section 6.7.3.2, software needs
> 
> Would you like to use key words in consistent ways also in such a change description?

Will do. thanks

> 
> > to wait at least 1 second for the command-complete event, before
> > resending the cmd or …
> 
>                 command?

Yes.

> …
> > ---
> > Changlog:
> >
> >   since v1:
> …
> 
> Are cover letters generally desirable for patch series?

The 2 patches solve different issue, and not logically relevant. But
I'll try in next version.

Thanks,
Feng

> Regards,
> Markus