linux-kernel - Re: [PATCH] selftests:sysctl:Fix minor grammers in sysctl test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502190912.CA03B56796@keescook>
Date: Wed, 19 Feb 2025 09:13:04 -0800
From: Kees Cook <kees@...nel.org>
To: Sumya Hoque <sumyahoque2012@...il.com>
Cc: skhan@...uxfoundation.org, linux-kernel@...r.kernel.org,
	shuah@...nel.org, linux-fsdevel@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] selftests:sysctl:Fix minor grammers in sysctl test

On Wed, Feb 19, 2025 at 03:04:51AM +0000, Sumya Hoque wrote:
> Hello everyone,
> Some minor grammer issues that I have fixed:
> 1. echo "If an error every occurs -->  echo "If an error occurs, every execution
> 2. Example uses --> Example Usage 
> 
> Signed-off-by: Sumya Hoque <sumyahoque2012@...il.com>
> ---
>  tools/testing/selftests/sysctl/sysctl.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/sysctl/sysctl.sh b/tools/testing/selftests/sysctl/sysctl.sh
> index 84472b436c07..a4d76147ed8a 100755
> --- a/tools/testing/selftests/sysctl/sysctl.sh
> +++ b/tools/testing/selftests/sysctl/sysctl.sh
> @@ -891,11 +891,11 @@ usage()
>  	echo "    -l      List all test ID list"
>  	echo " -h|--help  Help"
>  	echo
> -	echo "If an error every occurs execution will immediately terminate."
> +	echo "If an error occurs, every execution will immediately terminate."

I think the typo here is just "every" -> "ever"

>  	echo "If you are adding a new test try using -w <test-ID> first to"
>  	echo "make sure the test passes a series of tests."
>  	echo
> -	echo Example uses:
> +	echo Example usage:
>  	echo
>  	echo "$TEST_NAME.sh            -- executes all tests"
>  	echo "$TEST_NAME.sh -t 0002    -- Executes test ID 0002 number of times is recomended"
> -- 
> 2.34.1
> 

-- 
Kees Cook