linux-kernel - Re: [PATCH v6 3/6] syscall.h: introduce syscall_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2502191658530.65342@angie.orcam.me.uk>
Date: Wed, 19 Feb 2025 17:16:05 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: "Dmitry V. Levin" <ldv@...ace.io>
cc: Andrew Morton <akpm@...ux-foundation.org>, Oleg Nesterov <oleg@...hat.com>, 
    Alexey Gladkov <legion@...nel.org>, 
    Eugene Syromyatnikov <evgsyr@...il.com>, 
    Charlie Jenkins <charlie@...osinc.com>, Helge Deller <deller@....de>, 
    Mike Frysinger <vapier@...too.org>, Renzo Davoli <renzo@...unibo.it>, 
    Davide Berardi <berardi.dav@...il.com>, Vineet Gupta <vgupta@...nel.org>, 
    Russell King <linux@...linux.org.uk>, 
    Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, 
    Brian Cain <bcain@...cinc.com>, Huacai Chen <chenhuacai@...nel.org>, 
    WANG Xuerui <kernel@...0n.name>, Geert Uytterhoeven <geert@...ux-m68k.org>, 
    Michal Simek <monstr@...str.eu>, 
    Thomas Bogendoerfer <tsbogend@...ha.franken.de>, 
    Dinh Nguyen <dinguyen@...nel.org>, Jonas Bonn <jonas@...thpole.se>, 
    Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>, 
    Stafford Horne <shorne@...il.com>, 
    "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>, 
    Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>, 
    Christophe Leroy <christophe.leroy@...roup.eu>, 
    Naveen N Rao <naveen@...nel.org>, 
    Madhavan Srinivasan <maddy@...ux.ibm.com>, 
    Paul Walmsley <paul.walmsley@...ive.com>, 
    Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, 
    Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, 
    Alexander Gordeev <agordeev@...ux.ibm.com>, 
    Christian Borntraeger <borntraeger@...ux.ibm.com>, 
    Sven Schnelle <svens@...ux.ibm.com>, 
    Yoshinori Sato <ysato@...rs.sourceforge.jp>, Rich Felker <dalias@...c.org>, 
    John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>, 
    "David S. Miller" <davem@...emloft.net>, 
    Andreas Larsson <andreas@...sler.com>, Richard Weinberger <richard@....at>, 
    Anton Ivanov <anton.ivanov@...bridgegreys.com>, 
    Johannes Berg <johannes@...solutions.net>, 
    Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, 
    Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, 
    x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>, 
    Chris Zankel <chris@...kel.net>, Max Filippov <jcmvbkbc@...il.com>, 
    Arnd Bergmann <arnd@...db.de>, strace-devel@...ts.strace.io, 
    linux-snps-arc@...ts.infradead.org, linux-kernel@...r.kernel.org, 
    linux-arm-kernel@...ts.infradead.org, linux-hexagon@...r.kernel.org, 
    loongarch@...ts.linux.dev, linux-m68k@...ts.linux-m68k.org, 
    linux-mips@...r.kernel.org, linux-openrisc@...r.kernel.org, 
    linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, 
    linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org, 
    linux-sh@...r.kernel.org, sparclinux@...r.kernel.org, 
    linux-um@...ts.infradead.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH v6 3/6] syscall.h: introduce syscall_set_nr()

On Mon, 17 Feb 2025, Dmitry V. Levin wrote:

> diff --git a/arch/mips/include/asm/syscall.h b/arch/mips/include/asm/syscall.h
> index ea050b23d428..b956b015641c 100644
> --- a/arch/mips/include/asm/syscall.h
> +++ b/arch/mips/include/asm/syscall.h
> @@ -41,6 +41,20 @@ static inline long syscall_get_nr(struct task_struct *task,
>  	return task_thread_info(task)->syscall;
>  }
>  
> +static inline void syscall_set_nr(struct task_struct *task,
> +				  struct pt_regs *regs,
> +				  int nr)
> +{
> +	/*
> +	 * New syscall number has to be assigned to regs[2] because
> +	 * syscall_trace_entry() loads it from there unconditionally.

 That label is called `trace_a_syscall' in arch/mips/kernel/scall64-o32.S 
instead.  To bring some order and avoid an inaccuracy here should the odd 
one be matched to the other three?

> +	 *
> +	 * Consequently, if the syscall was indirect and nr != __NR_syscall,
> +	 * then after this assignment the syscall will cease to be indirect.
> +	 */
> +	task_thread_info(task)->syscall = regs->regs[2] = nr;
> +}
> +
>  static inline void mips_syscall_update_nr(struct task_struct *task,
>  					  struct pt_regs *regs)
>  {

 Otherwise:

Reviewed-by: Maciej W. Rozycki <macro@...am.me.uk>

for this part, thank you!

  Maciej