linux-kernel - Re: [PATCH net-next v2] net: Remove redundant variable declaration in __dev_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <173993164649.106119.12528129240098678219.git-patchwork-notify@kernel.org>
Date: Wed, 19 Feb 2025 02:20:46 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Breno Leitao <leitao@...ian.org>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, horms@...nel.org, nicolas.dichtel@...nd.com,
 andrew@...n.ch, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 mateusz.polchlopek@...el.com
Subject: Re: [PATCH net-next v2] net: Remove redundant variable declaration in
 __dev_change_flags()

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 17 Feb 2025 07:48:13 -0800 you wrote:
> The old_flags variable is declared twice in __dev_change_flags(),
> causing a shadow variable warning. This patch fixes the issue by
> removing the redundant declaration, reusing the existing old_flags
> variable instead.
> 
> 	net/core/dev.c:9225:16: warning: declaration shadows a local variable [-Wshadow]
> 	9225 |                 unsigned int old_flags = dev->flags;
> 	|                              ^
> 	net/core/dev.c:9185:15: note: previous declaration is here
> 	9185 |         unsigned int old_flags = dev->flags;
> 	|                      ^
> 	1 warning generated.
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net: Remove redundant variable declaration in __dev_change_flags()
    https://git.kernel.org/netdev/net-next/c/8f02c48f8f62

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html