linux-kernel - Re: [PATCH 2/4] media: i2c: Add driver for Sony IMX728

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c929975d-6928-4161-b062-64636a4f278e@web.de>
Date: Wed, 19 Feb 2025 18:51:51 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Sebastian LaVine <slavine@...mbedded.com>,
 Stuart Burtner <sburtner@...mbedded.com>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org
Cc: LKML <linux-kernel@...r.kernel.org>, kernel@...gutronix.de,
 Abel Vesa <abel.vesa@...aro.org>,
 Alexander Stein <alexander.stein@...tq-group.com>,
 Angelo Gioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Ard Biesheuvel <ardb@...nel.org>,
 Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
 Biju Das <biju.das.jz@...renesas.com>,
 Bjorn Andersson <quic_bjorande@...cinc.com>,
 Catalin Marinas <catalin.marinas@....com>, Conor Dooley
 <conor+dt@...nel.org>, Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Devarsh Thakkar <devarsht@...com>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Elinor Montmasson <elinor.montmasson@...oirfairelinux.com>,
 Fabio Estevam <festevam@...il.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 Hans Verkuil <hverkuil@...all.nl>,
 Javier Carrasco <javier.carrasco@...fvision.net>, Jianzhong Xu <xuj@...com>,
 Julien Massot <julien.massot@...labora.com>,
 Kieran Bingham <kieran.bingham@...asonboard.com>,
 Kory Maincent <kory.maincent@...tlin.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Mikhail Rudenko <mike.rudenko@...il.com>,
 Nícolas F. R. A. Prado <nfraprado@...labora.com>,
 Nishanth Menon <nm@...com>, Rob Herring <robh@...nel.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
 Spencer Hill <shill@...ngineering.com>, Tero Kristo <kristo@...nel.org>,
 Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
 Umang Jain <umang.jain@...asonboard.com>, Vaishnav Achath
 <vaishnav.a@...com>, Vignesh Raghavendra <vigneshr@...com>,
 Will Deacon <will@...nel.org>, Zhi Mao <zhi.mao@...iatek.com>
Subject: Re: [PATCH 2/4] media: i2c: Add driver for Sony IMX728

> Adds a driver for the Sony IMX728 image sensor.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14-rc3#n94

…
> +++ b/drivers/media/i2c/imx728.c
> @@ -0,0 +1,9655 @@
…
> +static int imx728_set_stream(struct v4l2_subdev *sd, int enable)
> +{
> +       struct imx728 *imx728 = to_imx728(sd);
> +       int ret;
> +
> +       mutex_lock(&imx728->lock);
…
> +       __v4l2_ctrl_grab(imx728->ctrl.v_flip, enable);
> +
> +       mutex_unlock(&imx728->lock);
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&imx728->lock);”?
https://elixir.bootlin.com/linux/v6.14-rc3/source/include/linux/mutex.h#L201

Regards,
Markus