linux-kernel - Re: [PATCH v3 04/10] x86/traps: Allow custom fixups in handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250219181737.GC23004@noisy.programming.kicks-ass.net>
Date: Wed, 19 Feb 2025 19:17:37 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Kees Cook <kees@...nel.org>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org, alyssa.milburn@...el.com,
	scott.d.constable@...el.com, joao@...rdrivepizza.com,
	andrew.cooper3@...rix.com, jpoimboe@...nel.org,
	jose.marchesi@...cle.com, hjl.tools@...il.com,
	ndesaulniers@...gle.com, samitolvanen@...gle.com, nathan@...nel.org,
	ojeda@...nel.org, alexei.starovoitov@...il.com, mhiramat@...nel.org,
	jmill@....edu
Subject: Re: [PATCH v3 04/10] x86/traps: Allow custom fixups in handle_bug()

On Wed, Feb 19, 2025 at 09:55:10AM -0800, Kees Cook wrote:

> > @@ -340,6 +343,9 @@ static noinstr bool handle_bug(struct pt
> >  		break;
> >  	}
> >  
> > +	if (!handled && regs->ip != addr)
> > +		regs->ip = addr;
> 
> Can you add a comment above this just to help with people scanning
> through this code in the future, maybe:
> 
> 	/* Restore failure location if we're not continuing execution. */
> 
> 
> > +
> >  	if (regs->flags & X86_EFLAGS_IF)
> >  		raw_local_irq_disable();
> >  	instrumentation_end();

Done.