linux-kernel - Re: [PATCH v2] accel/amdxdna: Add missing include linux/slab.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c3075150-94f5-7187-007c-0037eaed6077@amd.com>
Date: Wed, 19 Feb 2025 10:47:13 -0800
From: Lizhi Hou <lizhi.hou@....com>
To: Jeffrey Hugo <quic_jhugo@...cinc.com>, Su Hui <suhui@...china.com>,
	<jacek.lawrynowicz@...ux.intel.com>, <min.ma@....com>, <ogabbay@...nel.org>
CC: <George.Yang@....com>, <dri-devel@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH v2] accel/amdxdna: Add missing include linux/slab.h


On 2/11/25 07:36, Jeffrey Hugo wrote:
> On 2/10/2025 6:53 PM, Su Hui wrote:
>> When compiling without CONFIG_IA32_EMULATION, there can be some errors:
>>
>> drivers/accel/amdxdna/amdxdna_mailbox.c: In function 
>> ‘mailbox_release_msg’:
>> drivers/accel/amdxdna/amdxdna_mailbox.c:197:2: error: implicit 
>> declaration
>> of function ‘kfree’.
>>    197 |  kfree(mb_msg);
>>        |  ^~~~~
>> drivers/accel/amdxdna/amdxdna_mailbox.c: In function 
>> ‘xdna_mailbox_send_msg’:
>> drivers/accel/amdxdna/amdxdna_mailbox.c:418:11: error:implicit 
>> declaration
>> of function ‘kzalloc’.
>>    418 |  mb_msg = kzalloc(sizeof(*mb_msg) + pkg_size, GFP_KERNEL);
>>        |           ^~~~~~~
>>
>> Add the missing include.
>>
>> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
>> Signed-off-by: Su Hui <suhui@...china.com>
>> Reviewed-by: Lizhi Hou <lizhi.hou@....com>
>
> Reviewed-by: Jeffrey Hugo <quic_jhugo@...cinc.com>

Pushed to drm-misc-fixes


Thanks,

Lizhi