linux-kernel - Re: [PATCH v6 3/6] syscall.h: introduce syscall_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2502191917420.65342@angie.orcam.me.uk>
Date: Wed, 19 Feb 2025 19:20:33 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: "Dmitry V. Levin" <ldv@...ace.io>
cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>, 
    Andrew Morton <akpm@...ux-foundation.org>, Oleg Nesterov <oleg@...hat.com>, 
    Alexey Gladkov <legion@...nel.org>, 
    Eugene Syromyatnikov <evgsyr@...il.com>, strace-devel@...ts.strace.io, 
    linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 3/6] syscall.h: introduce syscall_set_nr()

On Wed, 19 Feb 2025, Dmitry V. Levin wrote:

> >  That label is called `trace_a_syscall' in arch/mips/kernel/scall64-o32.S 
> > instead.  To bring some order and avoid an inaccuracy here should the odd 
> > one be matched to the other three?
> 
> Apparently, there are two instances of syscall_trace_entry(), one
> n32_syscall_trace_entry(), one trace_a_syscall(), and each of them
> is calling syscall_trace_enter(), not to be confused with
> syscall_trace_entry():

 Oh dear!

> I'd change the wording of my comment rather than try to disentangle this.
> After all, the most important here is that the new syscall number is
> loaded from regs[2] right after the syscall_trace_enter() invocation.

 Right.

> Would you be OK with the following wording:
> 	/*
> 	 * New syscall number has to be assigned to regs[2] because it is
> 	 * loaded from there unconditionally after syscall_trace_enter()
> 	 * invocation.

 May I suggest "[...] after return from syscall_trace_enter() invocation." 
instead?  Minor reformatting might be required for better visual alignment 
though.

  Maciej