linux-kernel - Re: [PATCH next] media: i2c: imx214: Fix uninitialized variable in imx214_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <426de13199c560301ed0a148d9ecd0155dfcff0f.camel@apitzsch.eu>
Date: Wed, 19 Feb 2025 20:13:15 +0100
From: André Apitzsch <git@...tzsch.eu>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Ricardo Ribalda <ribalda@...nel.org>, Sakari Ailus	
 <sakari.ailus@...ux.intel.com>, Mauro Carvalho Chehab <mchehab@...nel.org>,
  Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org, 	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] media: i2c: imx214: Fix uninitialized variable in
 imx214_set_ctrl()

Am Dienstag, dem 18.02.2025 um 16:05 +0300 schrieb Dan Carpenter:
> You can't pass uninitialized "ret" variables to cci_write().  It has
> to start as zero.
> 
> Fixes: 4f0aeba4f155 ("media: i2c: imx214: Convert to CCI register
> access helpers")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/media/i2c/imx214.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
> index 6c3f6f3c8b1f..68775ee8256e 100644
> --- a/drivers/media/i2c/imx214.c
> +++ b/drivers/media/i2c/imx214.c
> @@ -795,7 +795,7 @@ static int imx214_set_ctrl(struct v4l2_ctrl
> *ctrl)
>  					     struct imx214, ctrls);
>  	const struct v4l2_mbus_framefmt *format = NULL;
>  	struct v4l2_subdev_state *state;
> -	int ret;
> +	int ret = 0;
>  
>  	if (ctrl->id == V4L2_CID_VBLANK) {
>  		int exposure_max, exposure_def;

Thanks.

Reviewed-by: André Apitzsch <git@...tzsch.eu>