linux-kernel - Re: [PATCH] auxdisplay: MAX6959 should select BITREVERSE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdYRKacUyCWXooXbiKUraA8iXtoqj-TqKzGCFRe0jv9wQ@mail.gmail.com>
Date: Wed, 19 Feb 2025 21:53:58 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Andy Shevchenko <andy@...nel.org>, linux-kernel@...r.kernel.org, 
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] auxdisplay: MAX6959 should select BITREVERSE

On Wed, Feb 19, 2025 at 7:06 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> If CONFIG_BITREVERSE is not enabled:
>
>     max6959.c:(.text+0x92): undefined reference to `byte_rev_table'

Thanks for the fix patch!

> While at it, sort the existing selects alphabetically

In general it seems okay when headers are all generic, but...

...

>  config MAX6959
>         tristate "Maxim MAX6958/6959 7-segment LED controller"
>         depends on I2C
> -       select REGMAP_I2C
> +       select BITREVERSE
>         select LINEDISP
> +       select REGMAP_I2C

...

In this case I prefer to have them kinda grouped, so generic go first
and the subsystem related follows, something like just putting the
BITREVERSE selection before the REGMAP_I2C. With this you don't even
need to add a paragraph to the commit message.

-- 
With Best Regards,
Andy Shevchenko