linux-kernel - Re: [PATCH] cpupower: monitor: Exit with error status if execvp() fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88d440c0-6a84-4483-939e-9f69e1d7befe@linuxfoundation.org>
Date: Wed, 19 Feb 2025 13:27:30 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Yiwei Lin <s921975628@...il.com>, trenn@...e.com, shuah@...nel.org
Cc: jwyatt@...hat.com, jkacur@...hat.com, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] cpupower: monitor: Exit with error status if execvp()
 fail

On 2/11/25 03:05, Yiwei Lin wrote:
> In the case that we give a invalid command to idle_monitor for
> monitoring, the execvp() will fail and thus go to the next line.
> As a result, we'll see two differnt monitoring output. For
> example, running `cpupower monitor -i 5 invalidcmd` which `invalidcmd`
> is not executable.
> 
> Signed-off-by: Yiwei Lin <s921975628@...il.com>
> ---
>   tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c b/tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c
> index f746099b5dac..0fc0e229739d 100644
> --- a/tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c
> +++ b/tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c
> @@ -6,6 +6,7 @@
>    */
>   
>   
> +#include <errno.h>
>   #include <stdio.h>
>   #include <unistd.h>
>   #include <stdlib.h>
> @@ -295,6 +296,7 @@ int fork_it(char **argv)
>   	if (!child_pid) {
>   		/* child */
>   		execvp(argv[0], argv);

Good find.

Add a check for execvp() fail and print a message
to say that it is an invalid command and then exit.

thanks,
-- Shuah