linux-kernel - Re: [PATCH] scsi: ufs: core: Set default runtime/system PM levels before ufshcd_hba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1194feaa-ea58-42cb-96fd-8bfd348d9589@acm.org>
Date: Wed, 19 Feb 2025 12:36:19 -0800
From: Bart Van Assche <bvanassche@....org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 alim.akhtar@...sung.com, avri.altman@....com,
 James.Bottomley@...senPartnership.com, martin.petersen@...cle.com
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
 "Bao D . Nguyen" <quic_nguyenb@...cinc.com>
Subject: Re: [PATCH] scsi: ufs: core: Set default runtime/system PM levels
 before ufshcd_hba_init()

On 2/19/25 2:50 AM, Manivannan Sadhasivam wrote:
> Commit bb9850704c04 ("scsi: ufs: core: Honor runtime/system PM levels if
> set by host controller drivers") introduced the check for setting default
> PM levels only if the levels are uninitialized by the host controller
> drivers. But it missed the fact that the levels could initialized to 0
> (UFS_PM_LVL_0) on purpose by the controller drivers. Even though none of
> the drivers are doing so now, the logic should be fixed irrespectively.
> 
> So set the default levels unconditionally before calling ufshcd_hba_init()
> API which initializes the controller drivers. It ensures that the
> controller drivers could override the default levels if required.

Reviewed-by: Bart Van Assche <bvanassche@....org>