linux-kernel - Re: [PATCH] pm: cpupower: bench: Prevent NULL dereference on malloc failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9f137f62-e182-4f00-97c1-5dca6e25b316@linuxfoundation.org>
Date: Wed, 19 Feb 2025 13:51:35 -0700
From: Shuah Khan <skhan@...uxfoundation.org>
To: Zhongqiu Han <quic_zhonhan@...cinc.com>, trenn@...e.com,
 shuah@...nel.org, jwyatt@...hat.com, jkacur@...hat.com, peng.fan@....com
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] pm: cpupower: bench: Prevent NULL dereference on malloc
 failure

On 2/19/25 05:27, Zhongqiu Han wrote:
> If malloc returns NULL due to low memory, 'config' pointer can be NULL.
> Add a check to prevent NULL dereference.
> 
> Signed-off-by: Zhongqiu Han <quic_zhonhan@...cinc.com>
> ---
>   tools/power/cpupower/bench/parse.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tools/power/cpupower/bench/parse.c b/tools/power/cpupower/bench/parse.c
> index 080678d9d74e..bd67c758b33a 100644
> --- a/tools/power/cpupower/bench/parse.c
> +++ b/tools/power/cpupower/bench/parse.c
> @@ -121,6 +121,10 @@ FILE *prepare_output(const char *dirname)
>   struct config *prepare_default_config()
>   {
>   	struct config *config = malloc(sizeof(struct config));
> +	if (!config) {
> +		perror("malloc");
> +		return NULL;
> +	}
>   
>   	dprintf("loading defaults\n");
>   

Thanks. Applied for Linux 6.15-rc1 - will be included in pull request
to PM maintainer.

https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/log/?h=cpupower

thanks,
-- Shuah