Message-ID: <CAGsJ_4xzaTYcJuP+a=NqPX6-75YcSsdvTr_uxxYzpe0QwP08xg@mail.gmail.com>
Date: Thu, 20 Feb 2025 10:26:36 +1300
From: Barry Song <21cnbao@...il.com>
To: Lokesh Gidra <lokeshgidra@...gle.com>
Cc: Suren Baghdasaryan <surenb@...gle.com>, linux-mm@...ck.org, akpm@...ux-foundation.org, 
	linux-kernel@...r.kernel.org, zhengtangquan@...o.com, 
	Barry Song <v-songbaohua@...o.com>, Andrea Arcangeli <aarcange@...hat.com>, 
	Al Viro <viro@...iv.linux.org.uk>, Axel Rasmussen <axelrasmussen@...gle.com>, 
	Brian Geffon <bgeffon@...gle.com>, Christian Brauner <brauner@...nel.org>, 
	David Hildenbrand <david@...hat.com>, Hugh Dickins <hughd@...gle.com>, Jann Horn <jannh@...gle.com>, 
	Kalesh Singh <kaleshsingh@...gle.com>, "Liam R . Howlett" <Liam.Howlett@...cle.com>, 
	Matthew Wilcox <willy@...radead.org>, Michal Hocko <mhocko@...e.com>, Mike Rapoport <rppt@...nel.org>, 
	Nicolas Geoffray <ngeoffray@...gle.com>, Peter Xu <peterx@...hat.com>, 
	Ryan Roberts <ryan.roberts@....com>, Shuah Khan <shuah@...nel.org>, 
	ZhangPeng <zhangpeng362@...wei.com>, Yu Zhao <yuzhao@...gle.com>
Subject: Re: [PATCH RFC] mm: Fix kernel BUG when userfaultfd_move encounters swapcache

On Thu, Feb 20, 2025 at 10:03 AM Lokesh Gidra <lokeshgidra@...gle.com> wrote:
>
> On Wed, Feb 19, 2025 at 12:38 PM Barry Song <21cnbao@...il.com> wrote:
> >
> > On Thu, Feb 20, 2025 at 7:27 AM Suren Baghdasaryan <surenb@...gle.com> wrote:
> > >
> > > On Wed, Feb 19, 2025 at 3:25 AM Barry Song <21cnbao@...il.com> wrote:
> > > >
> > > > From: Barry Song <v-songbaohua@...o.com>
> > > >
> > > > userfaultfd_move() checks whether the PTE entry is present or a
> > > > swap entry.
> > > >
> > > > - If the PTE entry is present, move_present_pte() handles folio
> > > >   migration by setting:
> > > >
> > > >   src_folio->index = linear_page_index(dst_vma, dst_addr);
> > > >
> > > > - If the PTE entry is a swap entry, move_swap_pte() simply copies
> > > >   the PTE to the new dst_addr.
> > > >
> > > > This approach is incorrect because even if the PTE is a swap
> > > > entry, it can still reference a folio that remains in the swap
> > > > cache.
> > > >
> > > > If do_swap_page() is triggered, it may locate the folio in the
> > > > swap cache. However, during add_rmap operations, a kernel panic
> > > > can occur due to:
> > > >  page_pgoff(folio, page) != linear_page_index(vma, address)
> > >
> > > Thanks for the report and reproducer!
> > >
> > > >
> > > > $./a.out > /dev/null
> > > > [   13.336953] page: refcount:6 mapcount:1 mapping:00000000f43db19c index:0xffffaf150 pfn:0x4667c
> > > > [   13.337520] head: order:2 mapcount:1 entire_mapcount:0 nr_pages_mapped:1 pincount:0
> > > > [   13.337716] memcg:ffff00000405f000
> > > > [   13.337849] anon flags: 0x3fffc0000020459(locked|uptodate|dirty|owner_priv_1|head|swapbacked|node=0|zone=0|lastcpupid=0xffff)
> > > > [   13.338630] raw: 03fffc0000020459 ffff80008507b538 ffff80008507b538 ffff000006260361
> > > > [   13.338831] raw: 0000000ffffaf150 0000000000004000 0000000600000000 ffff00000405f000
> > > > [   13.339031] head: 03fffc0000020459 ffff80008507b538 ffff80008507b538 ffff000006260361
> > > > [   13.339204] head: 0000000ffffaf150 0000000000004000 0000000600000000 ffff00000405f000
> > > > [   13.339375] head: 03fffc0000000202 fffffdffc0199f01 ffffffff00000000 0000000000000001
> > > > [   13.339546] head: 0000000000000004 0000000000000000 00000000ffffffff 0000000000000000
> > > > [   13.339736] page dumped because: VM_BUG_ON_PAGE(page_pgoff(folio, page) != linear_page_index(vma, address))
> > > > [   13.340190] ------------[ cut here ]------------
> > > > [   13.340316] kernel BUG at mm/rmap.c:1380!
> > > > [   13.340683] Internal error: Oops - BUG: 00000000f2000800 [#1] PREEMPT SMP
> > > > [   13.340969] Modules linked in:
> > > > [   13.341257] CPU: 1 UID: 0 PID: 107 Comm: a.out Not tainted 6.14.0-rc3-gcf42737e247a-dirty #299
> > > > [   13.341470] Hardware name: linux,dummy-virt (DT)
> > > > [   13.341671] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
> > > > [   13.341815] pc : __page_check_anon_rmap+0xa0/0xb0
> > > > [   13.341920] lr : __page_check_anon_rmap+0xa0/0xb0
> > > > [   13.342018] sp : ffff80008752bb20
> > > > [   13.342093] x29: ffff80008752bb20 x28: fffffdffc0199f00 x27: 0000000000000001
> > > > [   13.342404] x26: 0000000000000000 x25: 0000000000000001 x24: 0000000000000001
> > > > [   13.342575] x23: 0000ffffaf0d0000 x22: 0000ffffaf0d0000 x21: fffffdffc0199f00
> > > > [   13.342731] x20: fffffdffc0199f00 x19: ffff000006210700 x18: 00000000ffffffff
> > > > [   13.342881] x17: 6c203d2120296567 x16: 6170202c6f696c6f x15: 662866666f67705f
> > > > [   13.343033] x14: 6567617028454741 x13: 2929737365726464 x12: ffff800083728ab0
> > > > [   13.343183] x11: ffff800082996bf8 x10: 0000000000000fd7 x9 : ffff80008011bc40
> > > > [   13.343351] x8 : 0000000000017fe8 x7 : 00000000fffff000 x6 : ffff8000829eebf8
> > > > [   13.343498] x5 : c0000000fffff000 x4 : 0000000000000000 x3 : 0000000000000000
> > > > [   13.343645] x2 : 0000000000000000 x1 : ffff0000062db980 x0 : 000000000000005f
> > > > [   13.343876] Call trace:
> > > > [   13.344045]  __page_check_anon_rmap+0xa0/0xb0 (P)
> > > > [   13.344234]  folio_add_anon_rmap_ptes+0x22c/0x320
> > > > [   13.344333]  do_swap_page+0x1060/0x1400
> > > > [   13.344417]  __handle_mm_fault+0x61c/0xbc8
> > > > [   13.344504]  handle_mm_fault+0xd8/0x2e8
> > > > [   13.344586]  do_page_fault+0x20c/0x770
> > > > [   13.344673]  do_translation_fault+0xb4/0xf0
> > > > [   13.344759]  do_mem_abort+0x48/0xa0
> > > > [   13.344842]  el0_da+0x58/0x130
> > > > [   13.344914]  el0t_64_sync_handler+0xc4/0x138
> > > > [   13.345002]  el0t_64_sync+0x1ac/0x1b0
> > > > [   13.345208] Code: aa1503e0 f000f801 910f6021 97ff5779 (d4210000)
> > > > [   13.345504] ---[ end trace 0000000000000000 ]---
> > > > [   13.345715] note: a.out[107] exited with irqs disabled
> > > > [   13.345954] note: a.out[107] exited with preempt_count 2
> > > >
> > > > Fully fixing it would be quite complex, requiring similar handling
> > > > of folios as done in move_present_pte.
> > >
> > > How complex would that be? Is it a matter of adding
> > > folio_maybe_dma_pinned() checks, doing folio_move_anon_rmap() and
> > > folio->index = linear_page_index like in move_present_pte() or
> > > something more?
> >
> > My main concern is still with large folios that require a split_folio()
> > during move_pages(), as the entire folio shares the same index and
> > anon_vma. However, userfaultfd_move() moves pages individually,
> > making a split necessary.
> >
> > However, in split_huge_page_to_list_to_order(), there is a:
> >
> >         if (folio_test_writeback(folio))
> >                 return -EBUSY;
> >
> > This is likely true for swapcache, right? However, even for move_present_pte(),
> > it simply returns -EBUSY:
> >
> > move_pages_pte()
> > {
> >                 /* at this point we have src_folio locked */
> >                 if (folio_test_large(src_folio)) {
> >                         /* split_folio() can block */
> >                         pte_unmap(&orig_src_pte);
> >                         pte_unmap(&orig_dst_pte);
> >                         src_pte = dst_pte = NULL;
> >                         err = split_folio(src_folio);
> >                         if (err)
> >                                 goto out;
> >
> >                         /* have to reacquire the folio after it got split */
> >                         folio_unlock(src_folio);
> >                         folio_put(src_folio);
> >                         src_folio = NULL;
> >                         goto retry;
> >                 }
> > }
> >
> > Do we need a folio_wait_writeback() before calling split_folio()?
> >
> > By the way, I have also reported that userfaultfd_move() has a fundamental
> > conflict with TAO (Cc'ed Yu Zhao), which has been part of the Android common
> > kernel. In this scenario, folios in the virtual zone won’t be split in
> > split_folio(). Instead, the large folio migrates into nr_pages small folios.
> >
> > Thus, the best-case scenario would be:
> >
> > mTHP -> migrate to small folios in split_folio() -> move small folios to
> > dst_addr
> >
> > While this works, it negates the performance benefits of
> > userfaultfd_move(), as it introduces two PTE operations (migration in
> > split_folio() and move in userfaultfd_move() while retry), nr_pages memory
> > allocations, and still requires one memcpy(). This could end up
> > performing even worse than userfaultfd_copy(), I guess.
> >
> > The worst-case scenario would be failing to allocate small folios in
> > split_folio(), then userfaultfd_move() might return -ENOMEM?
> >
> > Given these issues, I strongly recommend that ART hold off on upgrading
> > to userfaultfd_move() until these problems are fully understood and
> > resolved. Otherwise, we’re in for a rough ride!
>
> At the moment, ART GC doesn't work taking mTHP into consideration. We
> don't try to be careful in userspace to be large-page aligned or
> anything. Also, the MOVE ioctl implementation works either on
> huge-pages or on normal pages. IIUC, it can't handle mTHP large pages
> as a whole. But that's true for other userfaultfd ioctls as well. If
> we were to continue using COPY, it's not that it's in any way more
> friendly to mTHP than MOVE. In fact, that's one of the reasons I'm
> considering making the ART heap NO_HUGEPAGE to avoid the need for
> folio-split entirely.

Disabling mTHP is one way to avoid potential bugs. However, as long as
UFFDIO_MOVE is available, we can’t prevent others, aside from ART GC,
from using it, right? So, we still need to address these issues with mTHP.

If a trend-following Android app discovers the UFFDIO_MOVE API, it might
use it, and it may not necessarily know to disable hugepages. Doesn’t that
pose a risk?

>
> Furthermore, there are few cases in which COPY ioctl's overhead just
> doesn't make sense for ART GC. So starting to use MOVE ioctl is the
> right thing to do.
>
> What we need eventually to gain mTHP benefits is both MOVE ioctl to
> support large-page migration as well as GC code in userspace to work
> with mTHP in mind.
> >
> > >
> > > > For now, a quick solution
> > > > is to return -EBUSY.
> > > > I'd like to see others' opinions on whether a full fix is worth
> > > > pursuing.
> > > >
> > > > For anyone interested in reproducing it, the a.out test program is
> > > > as below,
> > > >
> > > >  #define _GNU_SOURCE
> > > >  #include <stdio.h>
> > > >  #include <stdlib.h>
> > > >  #include <string.h>
> > > >  #include <sys/mman.h>
> > > >  #include <sys/ioctl.h>
> > > >  #include <sys/syscall.h>
> > > >  #include <linux/userfaultfd.h>
> > > >  #include <fcntl.h>
> > > >  #include <pthread.h>
> > > >  #include <unistd.h>
> > > >  #include <poll.h>
> > > >  #include <errno.h>
> > > >
> > > >  #define PAGE_SIZE 4096
> > > >  #define REGION_SIZE (512 * 1024)
> > > >
> > > >  #ifndef UFFDIO_MOVE
> > > >  struct uffdio_move {
> > > >      __u64 dst;
> > > >      __u64 src;
> > > >      __u64 len;
> > > >      #define UFFDIO_MOVE_MODE_DONTWAKE        ((__u64)1<<0)
> > > >      #define UFFDIO_MOVE_MODE_ALLOW_SRC_HOLES ((__u64)1<<1)
> > > >      __u64 mode;
> > > >      __s64 move;
> > > >  };
> > > >  #define _UFFDIO_MOVE  (0x05)
> > > >  #define UFFDIO_MOVE   _IOWR(UFFDIO, _UFFDIO_MOVE, struct uffdio_move)
> > > >  #endif
> > > >
> > > >  void *src, *dst;
> > > >  int uffd;
> > > >
> > > >  void *madvise_thread(void *arg) {
> > > >      if (madvise(src, REGION_SIZE, MADV_PAGEOUT) == -1) {
> > > >          perror("madvise MADV_PAGEOUT");
> > > >      }
> > > >      return NULL;
> > > >  }
> > > >
> > > >  void *fault_handler_thread(void *arg) {
> > > >      struct uffd_msg msg;
> > > >      struct uffdio_move move;
> > > >      struct pollfd pollfd = { .fd = uffd, .events = POLLIN };
> > > >
> > > >      pthread_setcancelstate(PTHREAD_CANCEL_ENABLE, NULL);
> > > >      pthread_setcanceltype(PTHREAD_CANCEL_DEFERRED, NULL);
> > > >
> > > >      while (1) {
> > > >          if (poll(&pollfd, 1, -1) == -1) {
> > > >              perror("poll");
> > > >              exit(EXIT_FAILURE);
> > > >          }
> > > >
> > > >          if (read(uffd, &msg, sizeof(msg)) <= 0) {
> > > >              perror("read");
> > > >              exit(EXIT_FAILURE);
> > > >          }
> > > >
> > > >          if (msg.event != UFFD_EVENT_PAGEFAULT) {
> > > >              fprintf(stderr, "Unexpected event\n");
> > > >              exit(EXIT_FAILURE);
> > > >          }
> > > >
> > > >          move.src = (unsigned long)src + (msg.arg.pagefault.address - (unsigned long)dst);
> > > >          move.dst = msg.arg.pagefault.address & ~(PAGE_SIZE - 1);
> > > >          move.len = PAGE_SIZE;
> > > >          move.mode = 0;
> > > >
> > > >          if (ioctl(uffd, UFFDIO_MOVE, &move) == -1) {
> > > >              perror("UFFDIO_MOVE");
> > > >              exit(EXIT_FAILURE);
> > > >          }
> > > >      }
> > > >      return NULL;
> > > >  }
> > > >
> > > >  int main() {
> > > >  again:
> > > >      pthread_t thr, madv_thr;
> > > >      struct uffdio_api uffdio_api = { .api = UFFD_API, .features = 0 };
> > > >      struct uffdio_register uffdio_register;
> > > >
> > > >      src = mmap(NULL, REGION_SIZE, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
> > > >      if (src == MAP_FAILED) {
> > > >          perror("mmap src");
> > > >          exit(EXIT_FAILURE);
> > > >      }
> > > >      memset(src, 1, REGION_SIZE);
> > > >
> > > >      dst = mmap(NULL, REGION_SIZE, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
> > > >      if (dst == MAP_FAILED) {
> > > >          perror("mmap dst");
> > > >          exit(EXIT_FAILURE);
> > > >      }
> > > >
> > > >      uffd = syscall(SYS_userfaultfd, O_CLOEXEC | O_NONBLOCK);
> > > >      if (uffd == -1) {
> > > >          perror("userfaultfd");
> > > >          exit(EXIT_FAILURE);
> > > >      }
> > > >
> > > >      if (ioctl(uffd, UFFDIO_API, &uffdio_api) == -1) {
> > > >          perror("UFFDIO_API");
> > > >          exit(EXIT_FAILURE);
> > > >      }
> > > >
> > > >      uffdio_register.range.start = (unsigned long)dst;
> > > >      uffdio_register.range.len = REGION_SIZE;
> > > >      uffdio_register.mode = UFFDIO_REGISTER_MODE_MISSING;
> > > >
> > > >      if (ioctl(uffd, UFFDIO_REGISTER, &uffdio_register) == -1) {
> > > >          perror("UFFDIO_REGISTER");
> > > >          exit(EXIT_FAILURE);
> > > >      }
> > > >
> > > >      if (pthread_create(&madv_thr, NULL, madvise_thread, NULL) != 0) {
> > > >          perror("pthread_create madvise_thread");
> > > >          exit(EXIT_FAILURE);
> > > >      }
> > > >
> > > >      if (pthread_create(&thr, NULL, fault_handler_thread, NULL) != 0) {
> > > >          perror("pthread_create fault_handler_thread");
> > > >          exit(EXIT_FAILURE);
> > > >      }
> > > >
> > > >      for (size_t i = 0; i < REGION_SIZE; i += PAGE_SIZE) {
> > > >          char val = ((char *)dst)[i];
> > > >          printf("Accessing dst at offset %zu, value: %d\n", i, val);
> > > >      }
> > > >
> > > >      pthread_join(madv_thr, NULL);
> > > >      pthread_cancel(thr);
> > > >      pthread_join(thr, NULL);
> > > >
> > > >      munmap(src, REGION_SIZE);
> > > >      munmap(dst, REGION_SIZE);
> > > >      close(uffd);
> > > >      goto again;
> > > >      return 0;
> > > >  }
> > > >
> > > > As long as you enable mTHP (which likely increases the residency
> > > > time of swapcache), you can reproduce the issue within a few
> > > > seconds. But I guess the same race condition also exists with
> > > > small folios.
> > > >
> > > > Fixes: adef440691bab ("userfaultfd: UFFDIO_MOVE uABI")
> > > > Cc: Andrea Arcangeli <aarcange@...hat.com>
> > > > Cc: Suren Baghdasaryan <surenb@...gle.com>
> > > > Cc: Al Viro <viro@...iv.linux.org.uk>
> > > > Cc: Axel Rasmussen <axelrasmussen@...gle.com>
> > > > Cc: Brian Geffon <bgeffon@...gle.com>
> > > > Cc: Christian Brauner <brauner@...nel.org>
> > > > Cc: David Hildenbrand <david@...hat.com>
> > > > Cc: Hugh Dickins <hughd@...gle.com>
> > > > Cc: Jann Horn <jannh@...gle.com>
> > > > Cc: Kalesh Singh <kaleshsingh@...gle.com>
> > > > Cc: Liam R. Howlett <Liam.Howlett@...cle.com>
> > > > Cc: Lokesh Gidra <lokeshgidra@...gle.com>
> > > > Cc: Matthew Wilcox (Oracle) <willy@...radead.org>
> > > > Cc: Michal Hocko <mhocko@...e.com>
> > > > Cc: Mike Rapoport (IBM) <rppt@...nel.org>
> > > > Cc: Nicolas Geoffray <ngeoffray@...gle.com>
> > > > Cc: Peter Xu <peterx@...hat.com>
> > > > Cc: Ryan Roberts <ryan.roberts@....com>
> > > > Cc: Shuah Khan <shuah@...nel.org>
> > > > Cc: ZhangPeng <zhangpeng362@...wei.com>
> > > > Signed-off-by: Barry Song <v-songbaohua@...o.com>
> > > > ---
> > > >  mm/userfaultfd.c | 11 +++++++++++
> > > >  1 file changed, 11 insertions(+)
> > > >
> > > > diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c
> > > > index 867898c4e30b..34cf1c8c725d 100644
> > > > --- a/mm/userfaultfd.c
> > > > +++ b/mm/userfaultfd.c
> > > > @@ -18,6 +18,7 @@
> > > >  #include <asm/tlbflush.h>
> > > >  #include <asm/tlb.h>
> > > >  #include "internal.h"
> > > > +#include "swap.h"
> > > >
> > > >  static __always_inline
> > > >  bool validate_dst_vma(struct vm_area_struct *dst_vma, unsigned long dst_end)
> > > > @@ -1079,9 +1080,19 @@ static int move_swap_pte(struct mm_struct *mm,
> > > >                          pmd_t *dst_pmd, pmd_t dst_pmdval,
> > > >                          spinlock_t *dst_ptl, spinlock_t *src_ptl)
> > > >  {
> > > > +       struct folio *folio;
> > > > +       swp_entry_t entry;
> > > > +
> > > >         if (!pte_swp_exclusive(orig_src_pte))
> > > >                 return -EBUSY;
> > > >
> > >
> > > Would be helpful to add a comment explaining that this is the case
> > > when the folio is in the swap cache.
> > >
> > > > +       entry = pte_to_swp_entry(orig_src_pte);
> > > > +       folio = filemap_get_folio(swap_address_space(entry), swap_cache_index(entry));
> > > > +       if (!IS_ERR(folio)) {
> > > > +               folio_put(folio);
> > > > +               return -EBUSY;
> > > > +       }
> > > > +
> > > >         double_pt_lock(dst_ptl, src_ptl);
> > > >
> > > >         if (!is_pte_pages_stable(dst_pte, src_pte, orig_dst_pte, orig_src_pte,
> > > > --
> > > > 2.39.3 (Apple Git-146)
> > > >
> >

Thanks
Barry

Powered by blists - more mailing lists