linux-kernel - Re: [PATCH v2 7/8] reset: imx8mp-audiomix: Add support for DSP run/stall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z7ZNz4duF4okP2P2@lizhi-Precision-Tower-5810>
Date: Wed, 19 Feb 2025 16:31:59 -0500
From: Frank Li <Frank.li@....com>
To: Daniel Baluta <daniel.baluta@....com>
Cc: p.zabel@...gutronix.de, robh@...nel.org, shawnguo@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, s.hauer@...gutronix.de,
	kernel@...gutronix.de, festevam@...il.com,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	mathieu.poirier@...aro.org, shengjiu.wang@....com, peng.fan@....com,
	laurentiu.mihalcea@....com, iuliana.prodan@....com
Subject: Re: [PATCH v2 7/8] reset: imx8mp-audiomix: Add support for DSP
 run/stall

On Wed, Feb 19, 2025 at 09:21:01PM +0200, Daniel Baluta wrote:
> We can Run/Stall the DSP via audio block control bits found in audiomix.
> Implement this functionality using the reset controller and use assert
> for Stall and deassert for Run.
>
> Signed-off-by: Daniel Baluta <daniel.baluta@....com>

Reviewed-by: Frank Li <Frank.Li@....com>

> ---
>  drivers/reset/reset-imx8mp-audiomix.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c
> index 42539cafbccc..4a713b772429 100644
> --- a/drivers/reset/reset-imx8mp-audiomix.c
> +++ b/drivers/reset/reset-imx8mp-audiomix.c
> @@ -16,6 +16,9 @@
>  #define IMX8MP_AUDIOMIX_EARC_RESET_MASK		BIT(1)
>  #define IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK	BIT(2)
>
> +#define IMX8MP_AUDIOMIX_DSP_OFFSET		0x108
> +#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK	BIT(5)
> +
>  struct imx8mp_reset_map {
>  	unsigned int offset;
>  	unsigned int mask;
> @@ -33,6 +36,11 @@ static const struct imx8mp_reset_map reset_map[] = {
>  		.mask	= IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK,
>  		.active_low = true,
>  	},
> +	[IMX8MP_AUDIOMIX_DSP] = {
> +		.offset	= IMX8MP_AUDIOMIX_DSP_OFFSET,
> +		.mask	= IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK,
> +		.active_low = false,
> +	},
>  };
>
>  struct imx8mp_audiomix_reset {
> --
> 2.25.1
>