linux-kernel - Re: [PATCH] yama: don't abuse rcu_read_lock/get_task_struct in yama_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250219214218.GF5948@redhat.com>
Date: Wed, 19 Feb 2025 22:42:18 +0100
From: Oleg Nesterov <oleg@...hat.com>
To: Kees Cook <kees@...nel.org>
Cc: Paul Moore <paul@...l-moore.com>, James Morris <jmorris@...ei.org>,
	"Serge E. Hallyn" <serge@...lyn.com>,
	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] yama: don't abuse rcu_read_lock/get_task_struct in
 yama_task_prctl()

Damn, sorry for the spam ;)

On 02/19, Oleg Nesterov wrote:
>
> Forgot to say...
>
> with or without this patch the usage of ptrace_relation->tracer/tracee
> doesn't look right (safe) to me... but probably I missed something
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Yes I did. I didn't realize that put_task_struct(tracer/tracee) calls
security_task_free() -> yama_task_free().

Sorry fo the noise.

Oleg.