linux-kernel - Re: [PATCH v5 1/1] cxl/pmem: debug invalid serial number data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67b64b347020a_2cf2f8294b4@iweiny-mobl.notmuch>
Date: Wed, 19 Feb 2025 15:20:52 -0600
From: Ira Weiny <ira.weiny@...el.com>
To: Yuquan Wang <wangyuquan1236@...tium.com.cn>, <dave@...olabs.net>,
	<jonathan.cameron@...wei.com>, <dave.jiang@...el.com>,
	<alison.schofield@...el.com>, <vishal.l.verma@...el.com>,
	<ira.weiny@...el.com>, <dan.j.williams@...el.com>
CC: <linux-cxl@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<chenbaozi@...tium.com.cn>, Yuquan Wang <wangyuquan1236@...tium.com.cn>
Subject: Re: [PATCH v5 1/1] cxl/pmem: debug invalid serial number data

Yuquan Wang wrote:
> In a nvdimm interleave-set each device with an invalid or zero
> serial number may cause pmem region initialization to fail, but in
> cxl case such device could still set cookies of nd_interleave_set
> and create a nvdimm pmem region.
> 
> This adds the validation of serial number in cxl pmem region creation.
> The event of no serial number would cause to fail to set the cookie
> and pmem region.
> 
> For cxl-test to work properly, always +1 on mock device's serial
> number.
> 
> Signed-off-by: Yuquan Wang <wangyuquan1236@...tium.com.cn>

Seems good.

Reviewed-by: Ira Weiny <ira.weiny@...el.com>

[snip]