linux-kernel - Re: [PATCH v4 2/2] gpiolib: don't build HTE code with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0bc59e86-fc8f-492a-846b-5d439cb8c5c6@nvidia.com>
Date: Wed, 19 Feb 2025 14:24:14 -0800
From: Dipen Patel <dipenp@...dia.com>
To: Bartosz Golaszewski <brgl@...ev.pl>,
 Linus Walleij <linus.walleij@...aro.org>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
 timestamp@...ts.linux.dev,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v4 2/2] gpiolib: don't build HTE code with CONFIG_HTE
 disabled

On 2/17/25 2:39 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> Hardware timestamping is only used on tegra186 platforms but we include
> the code and export the symbols everywhere. Shrink the binary a bit by
> compiling the relevant functions conditionally.
> 
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
> Changes in v4:
> - rebased after fixing conflicts
> 
>  drivers/gpio/gpiolib.c        |  2 ++
>  include/linux/gpio/consumer.h | 36 +++++++++++++++++++++--------------
>  2 files changed, 24 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index f261f7893f85..65ca749a1078 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -2906,6 +2906,7 @@ int gpiod_direction_output_nonotify(struct gpio_desc *desc, int value)
>  	return 0;
>  }
>  
> +#if IS_ENABLED(CONFIG_HTE)
>  /**
>   * gpiod_enable_hw_timestamp_ns - Enable hardware timestamp in nanoseconds.
>   *
> @@ -2971,6 +2972,7 @@ int gpiod_disable_hw_timestamp_ns(struct gpio_desc *desc, unsigned long flags)
>  	return ret;
>  }
>  EXPORT_SYMBOL_GPL(gpiod_disable_hw_timestamp_ns);
> +#endif /* CONFIG_HTE */
>  
>  /**
>   * gpiod_set_config - sets @config for a GPIO
> diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
> index 0dc49b5fca5c..0b2b56199c36 100644
> --- a/include/linux/gpio/consumer.h
> +++ b/include/linux/gpio/consumer.h
> @@ -114,8 +114,6 @@ int gpiod_get_direction(struct gpio_desc *desc);
>  int gpiod_direction_input(struct gpio_desc *desc);
>  int gpiod_direction_output(struct gpio_desc *desc, int value);
>  int gpiod_direction_output_raw(struct gpio_desc *desc, int value);
> -int gpiod_enable_hw_timestamp_ns(struct gpio_desc *desc, unsigned long flags);
> -int gpiod_disable_hw_timestamp_ns(struct gpio_desc *desc, unsigned long flags);
>  
>  /* Value get/set from non-sleeping context */
>  int gpiod_get_value(const struct gpio_desc *desc);
> @@ -347,18 +345,6 @@ static inline int gpiod_direction_output_raw(struct gpio_desc *desc, int value)
>  	WARN_ON(desc);
>  	return -ENOSYS;
>  }
> -static inline int gpiod_enable_hw_timestamp_ns(struct gpio_desc *desc,
> -					       unsigned long flags)
> -{
> -	WARN_ON(desc);
> -	return -ENOSYS;
> -}
> -static inline int gpiod_disable_hw_timestamp_ns(struct gpio_desc *desc,
> -						unsigned long flags)
> -{
> -	WARN_ON(desc);
> -	return -ENOSYS;
> -}
>  static inline int gpiod_get_value(const struct gpio_desc *desc)
>  {
>  	/* GPIO can never have been requested */
> @@ -559,6 +545,28 @@ struct gpio_desc *devm_fwnode_gpiod_get_index(struct device *dev,
>  
>  #endif /* CONFIG_GPIOLIB */
>  
> +#if IS_ENABLED(CONFIG_GPIOLIB) && IS_ENABLED(CONFIG_HTE)
> +int gpiod_enable_hw_timestamp_ns(struct gpio_desc *desc, unsigned long flags);
> +int gpiod_disable_hw_timestamp_ns(struct gpio_desc *desc, unsigned long flags);
> +#else
> +static inline int gpiod_enable_hw_timestamp_ns(struct gpio_desc *desc,
> +					       unsigned long flags)
> +{
> +	if (!IS_ENABLED(CONFIG_GPIOLIB))
> +		WARN_ON(desc);
> +
> +	return -ENOSYS;
> +}
> +static inline int gpiod_disable_hw_timestamp_ns(struct gpio_desc *desc,
> +						unsigned long flags)
> +{
> +	if (!IS_ENABLED(CONFIG_GPIOLIB))
> +		WARN_ON(desc);
> +
> +	return -ENOSYS;
> +}
> +#endif /* CONFIG_GPIOLIB && CONFIG_HTE */
> +
>  static inline
>  struct gpio_desc *devm_fwnode_gpiod_get(struct device *dev,
>  					struct fwnode_handle *fwnode,
Acked-by: Dipen Patel <dipenp@...dia.com>