linux-kernel - Re: [PATCH 2/8] dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250219225956.GA3127467-robh@kernel.org>
Date: Wed, 19 Feb 2025 16:59:56 -0600
From: Rob Herring <robh@...nel.org>
To: Claudiu Beznea <claudiu.beznea@...on.dev>
Cc: Ryan.Wanner@...rochip.com, krzk+dt@...nel.org, conor+dt@...nel.org,
	nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
	vkoul@...nel.org, wim@...ux-watchdog.org, linux@...ck-us.net,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org,
	linux-watchdog@...r.kernel.org
Subject: Re: [PATCH 2/8] dt-bindings: watchdog: sama5d4-wdt: Add sama7d65-wdt

On Tue, Feb 18, 2025 at 10:42:36AM +0200, Claudiu Beznea wrote:
> 
> 
> On 14.02.2025 20:08, Ryan.Wanner@...rochip.com wrote:
> > From: Ryan Wanner <Ryan.Wanner@...rochip.com>
> > 
> > Add microchip,sama7d65-wdt compatible string to the dt-binding documentation.
> > 
> > Signed-off-by: Ryan Wanner <Ryan.Wanner@...rochip.com>
> > ---
> >  .../devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml        | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> > index cdf87db361837..e9c026194d403 100644
> > --- a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> > @@ -23,6 +23,9 @@ properties:
> >            - const: microchip,sam9x7-wdt
> >            - const: microchip,sam9x60-wdt
> >
> 
> You could have keep this new line after the items section that you've added.
> 
> > +      - items:
> > +          - const: microchip,sama7d65-wdt
> > +          - const: microchip,sama7g5-wdt
> 
> here.

Please do.

> 
> >    reg:
> >      maxItems: 1
> >  
>