linux-kernel - Re: [PATCH v2 1/2] PCI/portdrv: Add necessary wait for disabling hotplug events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502191308.uQbXkZna-lkp@intel.com>
Date: Wed, 19 Feb 2025 13:57:23 +0800
From: kernel test robot <lkp@...el.com>
To: Feng Tang <feng.tang@...ux.alibaba.com>,
	Bjorn Helgaas <helgaas@...nel.org>, Lukas Wunner <lukas@...ner.de>,
	Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@...ux.intel.com>,
	Liguang Zhang <zhangliguang@...ux.alibaba.com>,
	Guanghui Feng <guanghuifeng@...ux.alibaba.com>, rafael@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, Markus Elfring <Markus.Elfring@....de>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	ilpo.jarvinen@...ux.intel.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Feng Tang <feng.tang@...ux.alibaba.com>
Subject: Re: [PATCH v2 1/2] PCI/portdrv: Add necessary wait for disabling
 hotplug events

Hi Feng,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/next]
[also build test WARNING on pci/for-linus linus/master v6.14-rc3 next-20250218]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Feng-Tang/PCI-Disable-PCIE-hotplug-interrupts-early-when-msi-is-disabled/20250218-115134
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link:    https://lore.kernel.org/r/20250218034859.40397-1-feng.tang%40linux.alibaba.com
patch subject: [PATCH v2 1/2] PCI/portdrv: Add necessary wait for disabling hotplug events
config: csky-randconfig-002-20250219 (https://download.01.org/0day-ci/archive/20250219/202502191308.uQbXkZna-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250219/202502191308.uQbXkZna-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502191308.uQbXkZna-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/pci/pcie/portdrv.c: In function 'pcie_wait_sltctl_cmd_raw':
>> drivers/pci/pcie/portdrv.c:212:18: warning: variable 'ret1' set but not used [-Wunused-but-set-variable]
     212 |         int ret, ret1, timeout_us;
         |                  ^~~~


vim +/ret1 +212 drivers/pci/pcie/portdrv.c

   208	
   209	static int pcie_wait_sltctl_cmd_raw(struct pci_dev *dev)
   210	{
   211		u16 slot_status = 0;
 > 212		int ret, ret1, timeout_us;
   213	
   214		/* 1 second, according to PCIe spec 6.1, section 6.7.3.2 */
   215		timeout_us = 1000000;
   216		ret = read_poll_timeout(pcie_capability_read_word, ret1,
   217					(slot_status & PCI_EXP_SLTSTA_CC), 10000,
   218					timeout_us, true, dev, PCI_EXP_SLTSTA,
   219					&slot_status);
   220		if (!ret)
   221			pcie_capability_write_word(dev, PCI_EXP_SLTSTA,
   222							PCI_EXP_SLTSTA_CC);
   223	
   224		return  ret;
   225	}
   226	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki