linux-kernel - Re: [PATCH v2 5/5] mm: memory-failure: move return value documentation to function declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdea7f63-c5ec-2e3b-8c88-e0a7ea745285@huawei.com>
Date: Wed, 19 Feb 2025 14:31:14 +0800
From: Miaohe Lin <linmiaohe@...wei.com>
To: Shuai Xue <xueshuai@...ux.alibaba.com>
CC: <tglx@...utronix.de>, <mingo@...hat.com>, <dave.hansen@...ux.intel.com>,
	<x86@...nel.org>, <hpa@...or.com>, <akpm@...ux-foundation.org>,
	<peterz@...radead.org>, <jpoimboe@...nel.org>, <linux-edac@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
	<baolin.wang@...ux.alibaba.com>, <tianruidong@...ux.alibaba.com>,
	<tony.luck@...el.com>, <bp@...en8.de>, <nao.horiguchi@...il.com>
Subject: Re: [PATCH v2 5/5] mm: memory-failure: move return value
 documentation to function declaration

On 2025/2/17 14:33, Shuai Xue wrote:
> Part of return value comments for memory_failure() were originally
> documented at the call site. Move those comments to the function
> declaration to improve code readability and to provide developers with
> immediate access to function usage and return information.
> 
> Signed-off-by: Shuai Xue <xueshuai@...ux.alibaba.com>
> Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Reviewed-by: Yazen Ghannam <yazen.ghannam@....com>
> Reviewed-by: Jane Chu <jane.chu@...cle.com>

LGTM.

Acked-by: Miaohe Lin <linmiaohe@...wei.com>
Thanks.
.