linux-kernel - Re: [PATCH 4/4] platform/x86: intel: Use *-y instead of *-objs in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5f539d9-8aeb-4272-938c-e3046df9cb50@intel.com>
Date: Tue, 18 Feb 2025 16:10:05 -0800
From: "Joseph, Jithu" <jithu.joseph@...el.com>
To: Kurt Borja <kuurtb@...il.com>, Ilpo Järvinen
	<ilpo.jarvinen@...ux.intel.com>
CC: <platform-driver-x86@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Hans de Goede <hdegoede@...hat.com>, Mario Limonciello
	<mario.limonciello@....com>, Andy Shevchenko
	<andriy.shevchenko@...ux.intel.com>, Ashok Raj <ashok.raj.linux@...il.com>,
	Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH 4/4] platform/x86: intel: Use *-y instead of *-objs in
 Makefile

On 2/18/2025 11:41 AM, Kurt Borja wrote:
> The `objs` suffix is reserved for user-space tools. Use the `y` suffix
> instead, which is usually used for kernel drivers.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Signed-off-by: Kurt Borja <kuurtb@...il.com>
> ---
>  drivers/platform/x86/intel/ifs/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks good to me (and verified that driver is getting built)

Reviewed-by: Jithu Joseph <jithu.joseph@...el.com>

> 
> diff --git a/drivers/platform/x86/intel/ifs/Makefile b/drivers/platform/x86/intel/ifs/Makefile
> index 30f035ef5581..c3e417bce9b6 100644
> --- a/drivers/platform/x86/intel/ifs/Makefile
> +++ b/drivers/platform/x86/intel/ifs/Makefile
> @@ -1,3 +1,3 @@
>  obj-$(CONFIG_INTEL_IFS)		+= intel_ifs.o
>  
> -intel_ifs-objs			:= core.o load.o runtest.o sysfs.o
> +intel_ifs-y			:= core.o load.o runtest.o sysfs.o


Thanks
Jithu