linux-kernel - Re: [PATCH 2/2] arm64: dts: socfpga: agilex5: add TB daughter board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cab7b294-a27c-438a-b6e1-b8928a8ad202@kernel.org>
Date: Wed, 19 Feb 2025 08:04:39 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: niravkumar.l.rabara@...el.com, Dinh Nguyen <dinguyen@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, nirav.rabara@...era.com,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: socfpga: agilex5: add TB daughter board
 support

On 18/02/2025 10:44, niravkumar.l.rabara@...el.com wrote:
> @@ -0,0 +1,27 @@
> +// SPDX-License-Identifier:     GPL-2.0
> +/*
> + * Copyright (C) 2025, Altera Corporation
> + */
> +#include "socfpga_agilex5_socdk.dts"
> +
> +/ {
> +	model = "SoCFPGA Agilex5 SoCDK - TB";
> +	compatible = "intel,socfpga-agilex5-socdk-tb", "intel,socfpga-agilex5";
> +
> +	leds {
> +		led-0 {
> +			label = "hps_led0";
> +			gpios = <&portb 12 GPIO_ACTIVE_HIGH>;
> +		};
> +	};
> +};
> +
> +&spi0 {
> +	status = "okay";
> +
> +	spidev@0{
> +		compatible = "rohm,dh2228fv";

NAK. You do not have such device there.

Also, follow DTS coding style and fix all white space issues here.

Best regards,
Krzysztof