linux-kernel - Re: [PATCH net-next] nfc: hci: Remove unused nfc_llc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69b10d11-72d3-42b4-a7af-8c9e72476674@kernel.org>
Date: Wed, 19 Feb 2025 08:25:07 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: linux@...blig.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, horms@...nel.org
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] nfc: hci: Remove unused nfc_llc_unregister

On 19/02/2025 03:02, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> nfc_llc_unregister() has been unused since it was added in 2012's
> commit 67cccfe17d1b ("NFC: Add an LLC Core layer to HCI")

... and it is basically part of nfc_llc_exit() already, so no need to
call it.

I would like to see that you actually investigated that this cleanup
should not be called, instead of just blindly removing code.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>


Best regards,
Krzysztof