linux-kernel - Re: [PATCH bpf-next 0/3] selftests/bpf: tc_links/tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3838d93-04e3-4e96-af53-e9e63550d7ba@bootlin.com>
Date: Wed, 19 Feb 2025 08:44:27 +0100
From: Bastien Curutchet <bastien.curutchet@...tlin.com>
To: Alexei Starovoitov <alexei.starovoitov@...il.com>,
 Stanislav Fomichev <stfomichev@...il.com>
Cc: Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>,
 Martin KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman
 <eddyz87@...il.com>, Song Liu <song@...nel.org>,
 Yonghong Song <yonghong.song@...ux.dev>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, Mykola Lysenko <mykolal@...com>,
 Shuah Khan <shuah@...nel.org>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 Alexis Lothore <alexis.lothore@...tlin.com>, bpf <bpf@...r.kernel.org>,
 "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next 0/3] selftests/bpf: tc_links/tc_opts: Unserialize
 tests

Hi,

On 2/19/25 4:40 AM, Alexei Starovoitov wrote:
> On Tue, Feb 18, 2025 at 1:22 PM Stanislav Fomichev <stfomichev@...il.com> wrote:
>>
>> On 02/17, Bastien Curutchet (eBPF Foundation) wrote:
>>> Hi all,
>>>
>>> Both tc_links.c and tc_opts.c do their tests on the loopback interface.
>>> It prevents from parallelizing their executions.
>>>
>>> Use namespaces and the new append_tid() helper to allow this
>>> parallelization.
>>>
>>> Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@...tlin.com>
>>
>> Acked-by: Stanislav Fomichev <sdf@...ichev.me>
>>
>> LGTM, thank you! Optionally, if there is more to convert, we can think
>> about moving create_and_open_tid_ns to the test_progs itself. For example,
>> if the test name starts with ns_, test_progs can probably do the
>> create_and_open_tid_ns/netns_free part?
> 
> That's a good idea.
> Let's do it now.
> Otherwise most of the patch 2 will be reverted when it's introduced.
> 

Ok, I'll send a V2 with this in test_progs.


Best regards,
Bastien