linux-kernel - Re: [PATCH 5/5] imx_dsp_rproc: Use reset controller API to control the DSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEnQRZCSL2ieQQFoHHpRwR5XfErZCm8nDMpr6rBVBWXiFKbm1A@mail.gmail.com>
Date: Wed, 19 Feb 2025 10:46:55 +0200
From: Daniel Baluta <daniel.baluta@...il.com>
To: Philipp Zabel <p.zabel@...gutronix.de>
Cc: Daniel Baluta <daniel.baluta@....com>, shawnguo@...nel.org, mathieu.poirier@...aro.org, 
	s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com, 
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, andersson@...nel.org, 
	linux-remoteproc@...r.kernel.org, iuliana.prodan@....com, 
	laurentiu.mihalcea@....com, shengjiu.wang@....com, Frank.Li@....com, 
	krzk@...nel.org
Subject: Re: [PATCH 5/5] imx_dsp_rproc: Use reset controller API to control
 the DSP

> > +     case IMX_RPROC_RESET_CONTROLLER:
> > +             priv->reset = devm_reset_control_get_optional_exclusive(dev, NULL);
>
> Is this optional on purpose? There is no mention of it in the commit
> message. Where is this resets property documented in the dt-bindings?

For this particular case on imx8mp the reset control shouldn't be optional
because the DSP won't really start without it.

I was thinking for future boards that might have a reset but which is
is not mandatory.

Will document the resets in v2.