linux-kernel - Re: [PATCH RESEND] HID: google: fix unused variable warning under !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1o9qp116-73rs-5202-o3rn-s1348670pn21@xreary.bet>
Date: Wed, 19 Feb 2025 10:04:45 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Yu-Chun Lin <eleanor15x@...il.com>
cc: bentiss@...nel.org, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org, visitorckw@...il.com, jserv@...s.ncku.edu.tw, 
    kernel test robot <lkp@...el.com>
Subject: Re: [PATCH RESEND] HID: google: fix unused variable warning under
 !CONFIG_ACPI

On Tue, 18 Feb 2025, Yu-Chun Lin wrote:

> As reported by the kernel test robot, the following warning occurs:
> 
> >> drivers/hid/hid-google-hammer.c:261:36: warning: 'cbas_ec_acpi_ids' defined but not used [-Wunused-const-variable=]
>      261 | static const struct acpi_device_id cbas_ec_acpi_ids[] = {
>          |                                    ^~~~~~~~~~~~~~~~
> 
> The 'cbas_ec_acpi_ids' array is only used when CONFIG_ACPI is enabled.
> Wrapping its definition and 'MODULE_DEVICE_TABLE' in '#ifdef CONFIG_ACPI'
> prevents a compiler warning when ACPI is disabled.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501201141.jctFH5eB-lkp@intel.com/
> Signed-off-by: Yu-Chun Lin <eleanor15x@...il.com>

I've added

	Fixes: eb1aac4c8744f75 ("HID: google: add support tablet mode switch for Whiskers")

and applied, thanks.

-- 
Jiri Kosina
SUSE Labs