linux-kernel - Re: [PATCH v4 6/8] reset: eyeq: drop device_set_of_node_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89d52c01503e2dbd2e23cce1ff9eb037e59eec5a.camel@pengutronix.de>
Date: Wed, 19 Feb 2025 10:16:21 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Jerome Brunet <jbrunet@...libre.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, Dave Ertman <david.m.ertman@...el.com>, Ira
 Weiny <ira.weiny@...el.com>, "Rafael J. Wysocki" <rafael@...nel.org>,
 Stephen Boyd <sboyd@...nel.org>, Arnd Bergmann <arnd@...db.de>, Danilo
 Krummrich <dakr@...nel.org>, Conor Dooley <conor.dooley@...rochip.com>,
 Daire McNamara <daire.mcnamara@...rochip.com>, Douglas Anderson
 <dianders@...omium.org>,  Andrzej Hajda <andrzej.hajda@...el.com>, Neil
 Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,  Jonas Karlman
 <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>, Maarten
 Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>,  Thomas Zimmermann <tzimmermann@...e.de>, David
 Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Hans de Goede
 <hdegoede@...hat.com>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>,  Bryan O'Donoghue
 <bryan.odonoghue@...aro.org>, Vladimir Kondratiev
 <vladimir.kondratiev@...ileye.com>, Gregory CLEMENT
 <gregory.clement@...tlin.com>, Théo Lebrun
 <theo.lebrun@...tlin.com>,  Michael Turquette <mturquette@...libre.com>,
 Abel Vesa <abelvesa@...nel.org>, Peng Fan <peng.fan@....com>, Shawn Guo
 <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix
 Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
 Kevin Hilman <khilman@...libre.com>,  Martin Blumenstingl
 <martin.blumenstingl@...glemail.com>
Cc: linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org, 
 dri-devel@...ts.freedesktop.org, platform-driver-x86@...r.kernel.org, 
 linux-mips@...r.kernel.org, linux-clk@...r.kernel.org, imx@...ts.linux.dev,
  linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH v4 6/8] reset: eyeq: drop device_set_of_node_from_dev()
 done by parent

On Di, 2025-02-18 at 20:29 +0100, Jerome Brunet wrote:
> From: Théo Lebrun <theo.lebrun@...tlin.com>
> 
> Our parent driver (clk-eyeq) now does the
> 	device_set_of_node_from_dev(dev, dev->parent)
> call through the newly introduced devm_auxiliary_device_create() helper.
> 
> Doing it again in the reset-eyeq probe would be redundant.
> Drop both the WARN_ON() and the device_set_of_node_from_dev() call.
> Also fix the following comment that talks about "our newfound OF node".
> 
> Signed-off-by: Théo Lebrun <theo.lebrun@...tlin.com>
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp