linux-kernel - Re: [PATCH v3] arm: pgtable: fix NULL pointer dereference issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM1KZSnM-imYwM5Gf4gw8yXr1+6PXyLvbpKbBu_KJmPR0WS7cA@mail.gmail.com>
Date: Wed, 19 Feb 2025 11:58:31 +0100
From: Ezra Buehler <ezra@...yb.ch>
To: Qi Zheng <zhengqi.arch@...edance.com>
Cc: linux@...linux.org.uk, david@...hat.com, hughd@...gle.com, 
	ryan.roberts@....com, akpm@...ux-foundation.org, muchun.song@...ux.dev, 
	linux-arm-kernel@...ts.infradead.org, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org, Ezra Buehler <ezra.buehler@...qvarnagroup.com>, 
	stable@...r.kernel.org
Subject: Re: [PATCH v3] arm: pgtable: fix NULL pointer dereference issue

On Mon, Feb 17, 2025 at 3:49 AM Qi Zheng <zhengqi.arch@...edance.com> wrote:
>
> When update_mmu_cache_range() is called by update_mmu_cache(), the vmf
> parameter is NULL, which will cause a NULL pointer dereference issue in
> adjust_pte():
>
> Unable to handle kernel NULL pointer dereference at virtual address 00000030 when read
> Hardware name: Atmel AT91SAM9
> PC is at update_mmu_cache_range+0x1e0/0x278
> LR is at pte_offset_map_rw_nolock+0x18/0x2c
> Call trace:
>  update_mmu_cache_range from remove_migration_pte+0x29c/0x2ec
>  remove_migration_pte from rmap_walk_file+0xcc/0x130
>  rmap_walk_file from remove_migration_ptes+0x90/0xa4
>  remove_migration_ptes from migrate_pages_batch+0x6d4/0x858
>  migrate_pages_batch from migrate_pages+0x188/0x488
>  migrate_pages from compact_zone+0x56c/0x954
>  compact_zone from compact_node+0x90/0xf0
>  compact_node from kcompactd+0x1d4/0x204
>  kcompactd from kthread+0x120/0x12c
>  kthread from ret_from_fork+0x14/0x38
> Exception stack(0xc0d8bfb0 to 0xc0d8bff8)
>
> To fix it, do not rely on whether 'ptl' is equal to decide whether to hold
> the pte lock, but decide it by whether CONFIG_SPLIT_PTE_PTLOCKS is
> enabled. In addition, if two vmas map to the same PTE page, there is no
> need to hold the pte lock again, otherwise a deadlock will occur. Just add
> the need_lock parameter to let adjust_pte() know this information.
>
> Reported-by: Ezra Buehler <ezra.buehler@...qvarnagroup.com>
> Closes: https://lore.kernel.org/lkml/CAM1KZSmZ2T_riHvay+7cKEFxoPgeVpHkVFTzVVEQ1BO0cLkHEQ@mail.gmail.com/
> Fixes: fc9c45b71f43 ("arm: adjust_pte() use pte_offset_map_rw_nolock()")
> Cc: stable@...r.kernel.org
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>
> Acked-by: David Hildenbrand <david@...hat.com>

Tested-by: Ezra Buehler <ezra.buehler@...qvarnagroup.com>

I confirm that this fixes our issue on the AT91SAM9G25-based GARDENA
smart Gateway.

However, unfortunately, I do not have a 4-core ARMv5 board at hand to
test the CONFIG_SPLIT_PTE_PTLOCKS case.

Cheers,
Ezra.