linux-kernel - Re: [PATCH v4 05/11] media: rockchip: add a driver for the rockchip camera interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <218b109e-a05f-42f2-b0bf-1b15d1a28b50@web.de>
Date: Wed, 19 Feb 2025 13:54:22 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Gerald Loacker <gerald.loacker@...fvision.net>,
 Maxime Chevallier <maxime.chevallier@...tlin.com>,
 Mehdi Djait <mehdi.djait@...tlin.com>,
 Michael Riesch <michael.riesch@...fvision.net>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, linux-rockchip@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org,
 Alexander Shiyan <eagle.alexander923@...il.com>,
 Conor Dooley <conor+dt@...nel.org>, Heiko Stübner
 <heiko@...ech.de>, Kever Yang <kever.yang@...k-chips.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Nicolas Dufresne <nicolas.dufresne@...labora.com>,
 Paul Kocialkowski <paulk@...-base.io>, Philipp Zabel
 <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Sebastian Fricke <sebastian.fricke@...labora.com>,
 Sebastian Reichel <sebastian.reichel@...labora.com>,
 Théo Lebrun <theo.lebrun@...tlin.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 Val Packett <val@...kett.cool>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Mehdi Djait <mehdi.djait@...ux.intel.com>
Subject: Re: [PATCH v4 05/11] media: rockchip: add a driver for the rockchip
 camera interface

…
> +++ b/drivers/media/platform/rockchip/rkcif/rkcif-stream.c
> @@ -0,0 +1,622 @@
…
> +static void rkcif_stream_push_buffer(struct rkcif_stream *stream,
> +				     struct rkcif_buffer *buffer)
> +{
> +	unsigned long lock_flags;
> +
> +	spin_lock_irqsave(&stream->driver_queue_lock, lock_flags);
> +	list_add_tail(&buffer->queue, &stream->driver_queue);
> +	spin_unlock_irqrestore(&stream->driver_queue_lock, lock_flags);
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&stream->driver_queue_lock);”?
https://elixir.bootlin.com/linux/v6.14-rc3/source/include/linux/spinlock.h#L572

Regards,
Markus