linux-kernel - Re: [PATCH] drm/imagination: only init job done fences once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <752175a8-1815-4bc7-9d40-b2ea3cbd72b1@imgtec.com>
Date: Wed, 19 Feb 2025 12:47:06 +0000
From: Matt Coster <Matt.Coster@...tec.com>
To: Brendan King <Brendan.King@...tec.com>
CC: Frank Binns <Frank.Binns@...tec.com>,
        Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/imagination: only init job done fences once

On 03/02/2025 15:31, Brendan King via B4 Relay wrote:
> From: Brendan King <Brendan.King@...tec.com>
> 
> Ensure job done fences are only initialised once.
> 
> This fixes a memory manager not clean warning from drm_mm_takedown
> on module unload.
> 
> Signed-off-by: Brendan King <brendan.king@...tec.com>

Hi Brendan,

Reviewed-by: Matt Coster <matt.coster@...tec.com>

Would you mind sending a V2 with "Cc: stable@...r.kernel.org" so this
fix will get picked up for stable backporting?

Cheers,
Matt

> ---
>  drivers/gpu/drm/imagination/pvr_queue.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_queue.c b/drivers/gpu/drm/imagination/pvr_queue.c
> index c4f08432882b12f5cdfeb7fc991fd941f0946676..9a67e646f1eae709859f664c796e1940f0b45300 100644
> --- a/drivers/gpu/drm/imagination/pvr_queue.c
> +++ b/drivers/gpu/drm/imagination/pvr_queue.c
> @@ -304,8 +304,9 @@ pvr_queue_cccb_fence_init(struct dma_fence *fence, struct pvr_queue *queue)
>  static void
>  pvr_queue_job_fence_init(struct dma_fence *fence, struct pvr_queue *queue)
>  {
> -	pvr_queue_fence_init(fence, queue, &pvr_queue_job_fence_ops,
> -			     &queue->job_fence_ctx);
> +	if (!fence->ops)
> +		pvr_queue_fence_init(fence, queue, &pvr_queue_job_fence_ops,
> +				     &queue->job_fence_ctx);
>  }
>  
>  /**
> 
> ---
> base-commit: 3ab334814dc7dff39075e055e12847d51878916e
> change-id: 20250131-init-done-fences-once-c55c5d0f4d8c
> 
> Best regards,

-- 
Matt Coster
E: matt.coster@...tec.com


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)