linux-kernel - Re: [PATCH 6/6] arm64: dts: mediatek: mt8390-genio-common: Add routes for DMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e7d7461-1af4-4e16-b808-072fe7c34e36@notapiano>
Date: Wed, 19 Feb 2025 10:30:19 -0300
From: Nícolas F. R. A. Prado <nfraprado@...labora.com>
To: Chen-Yu Tsai <wenst@...omium.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, kernel@...labora.com,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
	parkeryang <Parker.Yang@...iatek.com>
Subject: Re: [PATCH 6/6] arm64: dts: mediatek: mt8390-genio-common: Add
 routes for DMIC

On Wed, Feb 19, 2025 at 12:29:15PM +0800, Chen-Yu Tsai wrote:
> On Wed, Feb 19, 2025 at 5:27 AM Nícolas F. R. A. Prado
> <nfraprado@...labora.com> wrote:
> >
> > Add necessary routes for the onboard dual DMIC present on the Genio
> > 700/510 EVK. The dmic is supplied by micbias0 and micbias2, and inputs
> > into the MT8188 DMIC DAI.
> >
> > Co-developed-by: parkeryang <Parker.Yang@...iatek.com>
> > Signed-off-by: parkeryang <Parker.Yang@...iatek.com>
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
> > index a37cf102a6e928440cc88e7e8fe0225fc28ec962..efdeca88b8c4e58f0c17825156276babf19af145 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
> > @@ -959,7 +959,11 @@ &sound {
> >         pinctrl-0 = <&audio_default_pins>;
> >         audio-routing =
> >                 "Headphone", "Headphone L",
> > -               "Headphone", "Headphone R";
> > +               "Headphone", "Headphone R",
> > +               "DMIC_INPUT", "AP DMIC",
> > +               "AP DMIC", "AUDGLB",
> > +               "AP DMIC", "MIC_BIAS_0",
> > +               "AP DMIC", "MIC_BIAS_2";
> >         mediatek,adsp = <&adsp>;
> >         status = "okay";
> 
> Shouldn't there also be one or two new dmic-codecs, and a dai-link here?

The DMIC codec is only needed to get a wakeup delay and avoid an initial "pop"
noise. Same as for the analog mic, for which I've recently sent a patch [1].

Depending on the order that things get picked up, I can either add the patch for
it to this series, or the series in [1]. (Well, looks like I'll be sending a v2
for this series anyway, so I can add that patch here).

Thanks,
Nícolas

[1] https://lore.kernel.org/all/20250214-genio700-amic-wakeup-delay-200ms-v1-1-0094837c62b7@collabora.com