lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <874j0qqclr.fsf@bootlin.com>
Date: Wed, 19 Feb 2025 14:37:52 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Terence Eden <terence.eden@...spr.mobi>
Cc: maximlevitsky@...il.com,  richard@....at,  vigneshr@...com,
  linux-kernel@...r.kernel.org,  linux-mtd@...ts.infradead.org
Subject: Re: mtd: rawnand: r852: [PATCH] Fixed a spelling error in the comments

Hello Terence,

On 19/02/2025 at 11:59:10 GMT, Terence Eden <terence.eden@...spr.mobi> wrote:

> Continuing the work of Commit #8ab1b51 /
> https://lore.kernel.org/linux-mtd/20240923065649.11966-1-shenlichuan@vivo.com/
>
> This fixes a spelling error in the comments and removes an errant newline.
>
> Signed-off-by: Terence Eden <terence.eden@...spr.mobi>

I'm sorry but the formatting is still wrong:
- Your commit title should be "mtd: rawnand: r852: Fix a spelling error in the comments"
- I recommend you use git-format-patch or b4 to format your patches,
  which will prefix [PATCH] automatically.
- You need to increase the version when you send an iteration, this is
  v2, next will be v3 and this must be also done automatically by the
  tools, the final result should look like "[PATCH vX]".
- When sending a new iteration you need to give a changelog, and do that
outside of the commit log, ie...

> ---

  ^^^
Below these '---'

Thanks,
Miquèl

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ