linux-kernel - Re: [RESEND PATCH v2] PCI: Fix Extend ACS configurability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63aeb3d7-1758-4be0-8363-506d0c5635b8@nvidia.com>
Date: Wed, 19 Feb 2025 16:31:22 -0800
From: Tushar Dave <tdave@...dia.com>
To: Jason Gunthorpe <jgg@...dia.com>, bhelgaas@...gle.com
Cc: corbet@....net, paulmck@...nel.org, akpm@...ux-foundation.org,
 thuth@...hat.com, rostedt@...dmis.org, xiongwei.song@...driver.com,
 vidyas@...dia.com, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org, vsethi@...dia.com, sdonthineni@...dia.com
Subject: Re: [RESEND PATCH v2] PCI: Fix Extend ACS configurability



On 2/7/25 06:34, Jason Gunthorpe wrote:
> On Thu, Feb 06, 2025 at 07:03:38PM -0800, Tushar Dave wrote:
>> Commit 47c8846a49ba ("PCI: Extend ACS configurability") introduced
>> bugs that fail to configure ACS ctrl to the value specified by the
>> kernel parameter. Essentially there are two bugs.
>>
>> First, when ACS is configured for multiple PCI devices using
>> 'config_acs' kernel parameter, it results into error "PCI: Can't parse
>> ACS command line parameter". This is due to the bug in code that doesn't
>> preserve the ACS mask instead overwrites the mask with value 0.
> ..
> 
>> Fixes: 47c8846a49ba ("PCI: Extend ACS configurability")
>> Signed-off-by: Tushar Dave <tdave@...dia.com>
>> ---
>>
>> changes in v2:
>>   - Addressed review comments by Jason and Bjorn.
>>   - Removed Documentation changes (already taken care by other patch).
>>   - Amended commit description.
>>
>>   drivers/pci/pci.c | 17 ++++++++++++-----
>>   1 file changed, 12 insertions(+), 5 deletions(-)
> 
> Reviewed-by: Jason Gunthorpe <jgg@...dia.com>
> 
> Jason

Hi Bjorn,

Gentle reminder. Let me know if there are any review comments!

Thanks.
-Tushar