linux-kernel - Re: [PATCH] gpiolib: don't bail out if get_direction() fails in gpiochip_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174005695734.63211.7320786041973824393.b4-ty@linaro.org>
Date: Thu, 20 Feb 2025 14:09:19 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Mark Brown <broonie@...nel.org>,
	Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH] gpiolib: don't bail out if get_direction() fails in gpiochip_add_data()

From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>


On Wed, 19 Feb 2025 15:43:56 +0100, Bartosz Golaszewski wrote:
> Since commit 9d846b1aebbe ("gpiolib: check the return value of
> gpio_chip::get_direction()") we check the return value of the
> get_direction() callback as per its API contract. Some drivers have been
> observed to fail to register now as they may call get_direction() in
> gpiochip_add_data() in contexts where it has always silently failed.
> Until we audit all drivers, replace the bail-out to a kernel log
> warning.
> 
> [...]

Applied, thanks!

[1/1] gpiolib: don't bail out if get_direction() fails in gpiochip_add_data()
      commit: 96fa9ec477ff60bed87e1441fd43e003179f3253

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>